Do not use typedefs to hide that things are pointers #342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (80.49%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## TDE_REL_17_STABLE #342 +/- ##
=====================================================
- Coverage 80.49% 80.49% -0.01%
=====================================================
Files 22 22
Lines 2605 2604 -1
Branches 399 398 -1
=====================================================
- Hits 2097 2096 -1
Misses 430 430
Partials 78 78
🚀 New features to boost your workflow:
|
dAdAbird
reviewed
May 16, 2025
|
It is a weird habit from the PG project which is just annoying and many of the devs disagree with. I believe it is based on some idea that some data structures should be opaque and you just treat them as a handle. Let's do this! I hate these! |
|
Since we're 3/5 devs in the team liking this I'll convert it to a proper PR 😄 But won't merge if @dutow or @artemgavrilov hates it ofc. |
artemgavrilov
approved these changes
May 21, 2025
jeltz
approved these changes
May 21, 2025
And also remove the typedef that previously held the name TDESMgrRelation. This typedef hides the pointer-ness of things and only serves to make the code harder to read.
1ffd139 to
57716d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggestion renames
TDESMgrRelationDatatoTDESMgrRelationand removes the previous typedef that held that name. I think the code is much easier to read if we don't try to hide that something is a pointer using typedefs.The pointer hiding typedef is a common postgres code pattern however, so I understand if not everyone is on-board with this idea for consistency with the core code, but I though I should at least bring it up for discussion 🙂.