8000 Remove pointless struct from shmem code · percona/postgres@d67ad2a · GitHub
[go: up one dir, main page]

Skip to content

Commit d67ad2a

Browse files
committed
Remove pointless struct from shmem code
This struct just added extra mental overhead.
1 parent 1d1959d commit d67ad2a

File tree

1 file changed

+6
-16
lines changed

1 file changed

+6
-16
lines changed

contrib/pg_tde/src/common/pg_tde_shmem.c

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@
1717
#include "storage/lwlock.h"
1818
#include "storage/shmem.h"
1919

20-
typedef struct TdeSharedState
21-
{
22-
void *rawDsaArea; /* DSA area pointer to store cache hashes */
23-
} TdeSharedState;
24-
2520
static void tde_shmem_shutdown(int code, Datum arg);
2621

2722
List *registeredShmemRequests = NIL;
@@ -47,7 +42,6 @@ TdeRequiredSharedMemorySize(void)
4742
if (routine->required_shared_mem_size)
4843
sz = add_size(sz, routine->required_shared_mem_size());
4944
}
50-
sz = add_size(sz, sizeof(TdeSharedState));
5145
return MAXALIGN(sz);
5246
}
5347

@@ -61,25 +55,22 @@ void
6155
TdeShmemInit(void)
6256
{
6357
bool found;
64-
TdeSharedState *tdeState;
58+
char *free_start;
6559
Size required_shmem_size = TdeRequiredSharedMemorySize();
6660

6761
LWLockAcquire(AddinShmemInitLock, LW_EXCLUSIVE);
6862
/* Create or attach to the shared memory state */
6963
ereport(NOTICE, errmsg("TdeShmemInit: requested %ld bytes", required_shmem_size));
70-
tdeState = ShmemInitStruct("pg_tde", required_shmem_size, &found);
64+
free_start = ShmemInitStruct("pg_tde", required_shmem_size, &found);
7165

7266
if (!found)
7367
{
7468
/* First time through ... */
75-
char *p = (char *) tdeState;
7669
dsa_area *dsa;
7770
ListCell *lc;
7871
Size used_size = 0;
7972
Size dsa_area_size;
8073

81-
p += MAXALIGN(sizeof(TdeSharedState));
82-
used_size += MAXALIGN(sizeof(TdeSharedState));
8374
/* Now place all shared state structures */
8475
foreach(lc, registeredShmemRequests)
8576
{
@@ -88,19 +79,18 @@ TdeShmemInit(void)
8879

8980
if (routine->init_shared_state)
9081
{
91-
sz = routine->init_shared_state(p);
82+
sz = routine->init_shared_state(free_start);
9283
used_size += MAXALIGN(sz);
93-
p += MAXALIGN(sz);
84+
free_start += MAXALIGN(sz);
9485
Assert(used_size <= required_shmem_size);
9586
}
9687
}
9788
/* Create DSA area */
9889
dsa_area_size = required_shmem_size - used_size;
9990
Assert(dsa_area_size > 0);
100-
tdeState->rawDsaArea = p;
10191

10292
ereport(LOG, errmsg("creating DSA area of size %lu", dsa_area_size));
103-
dsa = dsa_create_in_place(tdeState->rawDsaArea,
93+
dsa = dsa_create_in_place(free_start,
10494
dsa_area_size,
10595
LWLockNewTrancheId(), 0);
10696
dsa_pin(dsa);
@@ -112,7 +102,7 @@ TdeShmemInit(void)
112102
TDEShmemSetupRoutine *routine = (TDEShmemSetupRoutine *) lfirst(lc);
113103

114104
if (routine->init_dsa_area_objects)
115-
routine->init_dsa_area_objects(dsa, tdeState->rawDsaArea);
105+
routine->init_dsa_area_objects(dsa, free_start);
116106
}
117107
ereport(LOG, errmsg("setting no limit to DSA area of size %lu", dsa_area_size));
118108

0 commit comments

Comments
 (0)
0