Stopgap patch for problem with cursors using hash joins: an ABORT

tglsfdc · tglsfdc · commit ae585b5c37ea · 2000-11-10T04:08:25.000Z
would cause two attempts to delete the hashtable portal, one from
query shutdown and one from portalmem.c.  Fix by making hash portals
be treated as 'special' portal names, so that CollectNamedPortals
will not think it should delete them.  This code is in need of
complete rewrite (and is already largely rewritten in current
sources), but still need to put a finger in the dike for 7.0.*.
diff --git a/src/backend/utils/mmgr/portalmem.c b/src/backend/utils/mmgr/portalmem.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/mmgr/portalmem.c,v 1.36 2000/04/12 17:16:10 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/mmgr/portalmem.c,v 1.36.2.1 2000/11/10 04:08:25 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -413,6 +413,12 @@ PortalNameIsSpecial(char *pname)
 		return true;
 	if (strcmp(pname, TRUNCPNAME) == 0)
 		return true;
+	/*
+	 * Quick hack for 7.0.3: treat hashtable portals as special
+	 * so that CollectNamedPortals() won't try to delete them.
+	 */
+	if (strncmp(pname, "<hashtable ", 11) == 0)
+		return true;
 	return false;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/mmgr/portalmem.c,v 1.36 2000/04/12 17:16:10 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/mmgr/portalmem.c,v 1.36.2.1 2000/11/10 04:08:25 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -413,6 +413,12 @@ PortalNameIsSpecial(char *pname)`
`413`	`413`	`return true;`
`414`	`414`	`if (strcmp(pname, TRUNCPNAME) == 0)`
`415`	`415`	`return true;`
	`416`	`+ /*`
	`417`	`+ * Quick hack for 7.0.3: treat hashtable portals as special`
	`418`	`+ * so that CollectNamedPortals() won't try to delete them.`
	`419`	`+ */`
	`420`	`+ if (strncmp(pname, "<hashtable ", 11) == 0)`
	`421`	`+ return true;`
`416`	`422`	`return false;`
`417`	`423`	`}`
`418`	`424`