Fix typo in setrefs.c

sfrost · sfrost · commit 0473e047877a · 2015-09-10T09:22:44.000-04:00
We're adding OIDs, not TIDs, to invalItems.

Pointed out by Etsuro Fujita.

Back-patch to all supported branches.
diff --git a/src/backend/optimizer/plan/setrefs.c b/src/backend/optimizer/plan/setrefs.c
@@ -765,7 +765,7 @@ copyVar(Var *var)
  * This is code that is common to all variants of expression-fixing.
  * We must look up operator opcode info for OpExpr and related nodes,
  * add OIDs from regclass Const nodes into glob->relationOids,
- * and add catalog TIDs for user-defined functions into glob->invalItems.
+ * and add catalog OIDs for user-defined functions into glob->invalItems.
  *
  * We assume it's okay to update opcode info in-place.  So this could possibly
  * scribble on the planner's input data structures, but it's OK.

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,7 @@ copyVar(Var *var)`
`765`	`765`	`* This is code that is common to all variants of expression-fixing.`
`766`	`766`	`* We must look up operator opcode info for OpExpr and related nodes,`
`767`	`767`	`* add OIDs from regclass Const nodes into glob->relationOids,`
`768`		`- * and add catalog TIDs for user-defined functions into glob->invalItems.`
	`768`	`+ * and add catalog OIDs for user-defined functions into glob->invalItems.`
`769`	`769`	`*`
`770`	`770`	`* We assume it's okay to update opcode info in-place. So this could possibly`
`771`	`771`	`* scribble on the planner's input data structures, but it's OK.`