feat: Explicitly exit the process to not wait for hanging promises (#51)

kamatsuoka · web-flow · commit 7d10bd0f83c6 · 2024-03-22T10:41:40.000+08:00
* Explicitly exit the process to not wait for hanging promises As with other actions like setup-node, I'm seeing 2-4 minute delays in post cache actions lately. Apparently this is because of a change in node behavior: ruby/setup-ruby#543 (comment) The fix, as with other actions, is to explicitly exit so as not to wait for hanging promises. * transpiled
diff --git a/dist/setup-pdm.js b/dist/setup-pdm.js
@@ -91128,6 +91128,7 @@ async function run() {
   } catch (error2) {
     core8.setFailed(error2.message);
   }
+  import_node_process4.default.exit();
 }
 run();
 /*! Bundled license information:
diff --git a/src/setup-pdm.ts b/src/setup-pdm.ts
@@ -67,6 +67,9 @@ async function run(): Promise<void> {
   catch (error: any) {
     core.setFailed(error.message)
   }
+  // Explicit process.exit() to not wait for hanging promises,
+  // see https://github.com/actions/setup-node/issues/878
+  process.exit()
 }
 
 run()

Original file line number	Diff line number	Diff line change
`@@ -91128,6 +91128,7 @@ async function run() {`
`91128`	`91128`	`} catch (error2) {`
`91129`	`91129`	`core8.setFailed(error2.message);`
`91130`	`91130`	`}`
	`91131`	`+ import_node_process4.default.exit();`
`91131`	`91132`	`}`
`91132`	`91133`	`run();`
`91133`	`91134`	`/*! Bundled license information:`
Original file line number	Diff line number	Diff line change
`@@ -67,6 +67,9 @@ async function run(): Promise<void> {`
`67`	`67`	`catch (error: any) {`
`68`	`68`	`core.setFailed(error.message)`
`69`	`69`	`}`
	`70`	`+ // Explicit process.exit() to not wait for hanging promises,`
	`71`	`+ // see https://github.com/actions/setup-node/issues/878`
	`72`	`+ process.exit()`
`70`	`73`	`}`
`71`	`74`
`72`	`75`	`run()`