Added a better way to generate oAuth nonces woocommerce#11

claudiosanches · claudiosanches · commit 00bc2fe25957 · 2016-02-16T17:20:52.000-02:00
diff --git a/woocommerce/oauth.py b/woocommerce/oauth.py
@@ -50,11 +50,7 @@ def get_oauth_url(self):
 
         params["oauth_consumer_key"] = self.consumer_key
         params["oauth_timestamp"] = int(time())
-        params["oauth_nonce"] = HMAC(
-            str(time() + randint(0, 99999)).encode(),
-            "secret".encode(),
-            sha1
-        ).hexdigest()
+        params["oauth_nonce"] = self.generate_nonce()
         params["oauth_signature_method"] = "HMAC-SHA256"
         params["oauth_signature"] = self.generate_oauth_signature(params, url)
 
@@ -131,3 +127,13 @@ def get_value_like_as_php(val):
             normalized_parameters[key] = value
 
         return normalized_parameters
+
+    @staticmethod
+    def generate_nonce():
+        """ Generate nonce number """
+        nonce = ''.join([str(randint(0, 9)) for i in range(8)])
+        return HMAC(
+            nonce.encode(),
+            "secret".encode(),
+            sha1
+        ).hexdigest()
