8000 Bug - Page - Whitespace on the left side of the screen from sidebar styling · Issue #7452 · patternfly/patternfly · GitHub
[go: up one dir, main page]

Skip to content

Bug - Page - Whitespace on the left side of the screen from sidebar styling #7452

@jenny-s51

Description

@jenny-s51

Describe the problem
This is an issue with

  • Patternfly 5
  • Patternfly 6 (6.2.0)
  • other

When we show an error as an alert at the top of the screen, it's got a buffer of whitespace between the left side of the screen and the alert due to this change.

How do you reproduce the problem?

In https://github.com/opendatahub-io/odh-dashboard

  1. Run npm install && npm run dev:start:ext in the frontend folder (after connecting to a cluster)
  2. Load up localhost & wait for the home page to show up
  3. CTRL+C the previous npm terminal
  4. Wait for timeout — see related images

Expected behavior

To fix the issue in https://github.com/opendatahub-io/odh-dashboard, we added this change cc @mattnolting - will need to apply the same fix here so we can remove this override in ODH.

.pf-v6-c-page {
  --pf-v6-c-page__sidebar--Width: 0;

  &:has(.pf-v6-c-page__sidebar) {
    --pf-v6-c-page__sidebar--Width: 18.125rem;
  }
}

Screenshots
If applicable, add screenshots to help explain the issue.

Current:
Image

Expected:
Image

What is your environment?

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]

What is your product and what release date are you targeting?
RHOAI 2.21

Any other information?
Following our discussion @mattnolting - we need to pass a check to verify that the sidebar exists to fix the alignment of the page content.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0