sass use/forward update follow ups

Just a couple of follow-ups from #6538

We should be able to remove this commented code

Lines 23 to 29 in 188ae60

    
           // This hack is to not include sass-utilities/placeholders.scss CSS more than once 
        
           // in our production patternfly.css BUT still be able to compile individual SCSS files. 
        
           // As soon as node-sass is updated to a libsass version that supports @use rule, we should 
        
           // `@use "../../sass-utilities/all";` 
        
           // if (numDirectories > 0) { 
        
           //   scss = `@use "${'../'.repeat(numDirectories)}config/_index";\n${scss}`; 
        
           // }

These @use imports at the top of pficon.scss were added, but that file is generated via yarn build:pficonfont from scripts/gulp/icons_template.scss, so we should move the imports to that template file - otherwise, they'll be blown away any time we generate new pficons

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sass use/forward update follow ups #6546

Metadata

Labels

Type

Projects

Milestone

Relationships

Development

	// This hack is to not include sass-utilities/placeholders.scss CSS more than once
	// in our production patternfly.css BUT still be able to compile individual SCSS files.
	// As soon as node-sass is updated to a libsass version that supports @use rule, we should
	// `@use "../../sass-utilities/all";`
	// if (numDirectories > 0) {
	// scss = `@use "${'../'.repeat(numDirectories)}config/_index";\n${scss}`;
	// }

sass use/forward update follow ups #6546

Description

Metadata

Metadata

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions