Use mmap.PAGESIZE constant as value for first read. (prometheus#505)

xavfernandez · web-flow · commit e58301600c47 · 2020-01-31T08:54:09.000Z
This size can have a real impact on performance when a lot of files need
to be read.
The performance relies heavily on the file system cache so reading as
little pages as possible helps a lot on memory constrained systems.

Signed-off-by: Xavier Fernandez &lt;xavier.fernandez@polyconseil.fr&gt;
diff --git a/prometheus_client/mmap_dict.py b/prometheus_client/mmap_dict.py
@@ -83,7 +83,7 @@ def read_all_values_from_file(filename):
         with open(filename, 'rb') as infp:
             # Read the first block of data, including the first 4 bytes which tell us
             # how much of the file (which is preallocated to _INITIAL_MMAP_SIZE bytes) is occupied.
-            data = infp.read(65535)
+            data = infp.read(mmap.PAGESIZE)
             used = _unpack_integer(data, 0)[0]
             if used > len(data):  # Then read in the rest, if needed.
                 data += infp.read(used - len(data))

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ def read_all_values_from_file(filename):`
`83`	`83`	`with open(filename, 'rb') as infp:`
`84`	`84`	`# Read the first block of data, including the first 4 bytes which tell us`
`85`	`85`	`# how much of the file (which is preallocated to _INITIAL_MMAP_SIZE bytes) is occupied.`
`86`		`- data = infp.read(65535)`
	`86`	`+ data = infp.read(mmap.PAGESIZE)`
`87`	`87`	`used = _unpack_integer(data, 0)[0]`
`88`	`88`	`if used > len(data): # Then read in the rest, if needed.`
`89`	`89`	`data += infp.read(used - len(data))`