Bump test coverage in fields: cover datatype and role attributes (tableau#64)

t8y8 · web-flow · commit 7041c9e0a64b · 2016-07-27T18:51:21.000+08:00
* Bump test coverage up a bit in fields
* Fix pep8 violation, and it fixed a few other things automatically as well
diff --git a/test/test_datasource.py b/test/test_datasource.py
@@ -19,6 +19,7 @@
 
 
 class DataSourceFieldsTDS(unittest.TestCase):
+
     def setUp(self):
         self.ds = Datasource.from_file(TEST_TDS_FILE)
 
@@ -51,21 +52,31 @@ def test_datasource_field_is_quantitative(self):
     def test_datasource_field_is_ordinal(self):
         self.assertTrue(self.ds.fields['[x]'].is_ordinal)
 
+    def test_datasource_field_datatype(self):
+        self.assertEqual(self.ds.fields['[x]'].datatype, 'integer')
+
+    def test_datasource_field_role(self):
+        self.assertEqual(self.ds.fields['[x]'].role, 'measure')
+
 
 class DataSourceFieldsTWB(unittest.TestCase):
+
     def setUp(self):
         self.wb = Workbook(TEST_TWB_FILE)
-        self.ds = self.wb.datasources[0]  # Assume the first datasource in the file
+        # Assume the first datasource in the file
+        self.ds = self.wb.datasources[0]
 
     def test_datasource_fields_loaded_in_workbook(self):
         self.assertIsNotNone(self.ds.fields)
         self.assertIsNotNone(self.ds.fields.get('[Number of Records]', None))
 
 
 class DataSourceFieldsFoundIn(unittest.TestCase):
+
     def setUp(self):
         self.wb = Workbook(TEST_TWB_FILE)
-        self.ds = self.wb.datasources[0]  # Assume the first datasource in the file
+        # Assume the first datasource in the file
+        self.ds = self.wb.datasources[0]
 
     def test_datasource_fields_found_in_returns_fields(self):
         actual_values = self.ds.fields.used_by_sheet('Sheet 1')
