8000 Remove abstractmethod that silently brake downstream packages (#15996) · panpiort8/scikit-learn@7b3f43f · GitHub
[go: up one dir, main page]

Skip to content

Commit 7b3f43f

Browse files
bsipoczPan Jan
authored andcommitted
Remove abstractmethod that silently brake downstream packages (scikit-learn#15996)
1 parent 69ca3f3 commit 7b3f43f

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

doc/whats_new/v0.22.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,13 @@ Changelog
5858
pass the `values_format` parameter to the :class:`ConfusionMatrixDisplay`
5959
plot() call. :pr:`15937` by :user:`Stephen Blystone <blynotes>`.
6060

61+
:mod:`sklearn.naive_bayes`
62+
..........................
63+
64+
- |Fix| removed abstract method `_check_X` from :class:`naive_bayes.BaseNB`
65+
that could break downstream projects inheriting from this deprecated
66+
public base class. :pr:`15996` by :user:`Brigitta Sipőcz <bsipocz>`.
67+
6168
:mod:`sklearn.semi_supervised`
6269
..............................
6370

sklearn/naive_bayes.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@ def _joint_log_likelihood(self, X):
5151
predict_proba and predict_log_proba.
5252
"""
5353

54-
@abstractmethod
55-
def _check_X(self, X):
56-
"""Validate input X
57-
"""
58-
pass
59-
6054
def predict(self, X):
6155
"""
6256
Perform classification on an array of test vectors X.

0 commit comments

Comments
 (0)
0