-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
CLN: isort imports - io dir #23332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: isort imports - io dir #23332
Conversation
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Hello @alimcmaster1! Thanks for submitting the PR.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm if green
pandas/io/clipboards.py, | ||
pandas/io/excel.py, | ||
pandas/io/date_converters.py, | ||
pandas/io/testing.py, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess as an extra callout this isn't in the diff, though I also don't see it existing as a module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot - my apologies I don't think this file ever existed in pandas running git log --full-history -- *pandas/io/testing.py
confirms this. I think I had a local file named this at one stage and it must have been present when I created the list of files to ignore.
Codecov Report
@@ Coverage Diff @@
## master #23332 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 169 169
Lines 50924 50924
=======================================
Hits 46968 46968
Misses 3956 3956
Continue to review full report at Codecov.
|
thanks @alimcmaster1 btw in the PR header, use xref issue number (and not closes) other GH will actually close the issue (IOW it doesn't understand partial) |
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Signed-off-by: alimcmaster1 <alimcmaster1@gmail.com>
Signed-off-by: alimcmaster1 alimcmaster1@gmail.com
Files in
pandas/io/*
( 1 of 2)git diff upstream/master -u -- "*.py" | flake8 --diff