FIX: define `DataFrame.items` for all versions of python #17214

tacaswell · 2017-08-10T15:31:38Z

gfyoung · 2017-08-10T15:32:35Z

pandas/tests/frame/test_api.py

@@ -164,6 +164,11 @@ def test_iteritems(self):
        for k, v in compat.iteritems(df):
            assert type(v) == Series

+    def test_items(self):
+        df = DataFrame([[1, 2, 3], [4, 5, 6]], columns=['a', 'a', 'b'])


Reference issue number.

gfyoung · 2017-08-10T15:33:35Z

pandas/tests/frame/test_api.py

+    def test_items(self):
+        df = DataFrame([[1, 2, 3], [4, 5, 6]], columns=['a', 'a', 'b'])
+        for k, v in df.items():
+            assert type(v) == Series


Do you think you could explicitly check the Series that you get for each iteration?

I just cargo-culted the test immediately above this that checks compat.iteritems(df) 😈

jreback · 2017-08-10T16:03:46Z

gfyoung · 2017-08-10T16:19:39Z

pandas/tests/frame/test_api.py

@@ -164,6 +164,15 @@ def test_iteritems(self):
        for k, v in compat.iteritems(df):
            assert type(v) == Series

+    def test_items(self):
+        # issue #17213


Let's reference #13918 as well here.

tacaswell · 2017-08-10T16:24:51Z

codecov · 2017-08-10T17:45:29Z

codecov · 2017-08-10T17:45:48Z

gfyoung · 2017-08-10T17:49:12Z

gfyoung · 2017-08-10T19:53:20Z

doc/source/whatsnew/v0.21.0.txt

@@ -126,6 +126,7 @@ Other Enhancements
 - :func:`date_range` now accepts 'Y' in addition to 'A' as an alias for end of year (:issue:`9313`)
 - Integration with `Apache Parquet <https://parquet.apache.org/>`__, including a new top-level :func:`read_parquet` and :func:`DataFrame.to_parquet` method, see :ref:`here <io.parquet>`.
 - :func:`DataFrame.add_prefix` and :func:`DataFrame.add_suffix` now accept strings containing the '%' character. (:issue:`17151`)
+- :func:`DataFrame.items` is present in both Python 2 and 3 and is lazy in all cases.


Reference both issue numbers here.

jreback · 2017-08-17T10:19:13Z

jreback

jreback · 2017-08-17T10:18:30Z

pandas/tests/frame/test_api.py

+        df = DataFrame([[1, 2, 3], [4, 5, 6]], columns=cols)
+        for c, (k, v) in zip(cols, df.items()):
+            assert c == k
+            assert type(v) == Series


isinstance(v, Series0

jreback · 2017-08-17T10:18:55Z

doc/source/whatsnew/v0.21.0.txt

@@ -126,6 +126,7 @@ Other Enhancements
 - :func:`date_range` now accepts 'Y' in addition to 'A' as an alias for end of year (:issue:`9313`)
 - Integration with `Apache Parquet <https://parquet.apache.org/>`__, including a new top-level :func:`read_parquet` and :func:`DataFrame.to_parquet` method, see :ref:`here <io.parquet>`.
 - :func:`DataFrame.add_prefix` and :func:`DataFrame.add_suffix` now accept strings containing the '%' character. (:issue:`17151`)
+- :func:`DataFrame.items` is present in both Python 2 and 3 and is lazy in all cases (:issue:`13918`, :issue:`17213`)


is now present.

tacaswell · 2017-08-19T20:35:54Z

tacaswell · 2017-08-19T20:36:50Z

jreback · 2017-08-19T21:59:23Z

@TomAugspurger

gfyoung added Bug API Design labels Aug 10, 2017

gfyoung reviewed Aug 10, 2017

View reviewed changes

tacaswell force-pushed the fix_items_everywhere branch from a551d10 to 145df9e Compare August 10, 2017 16:18

gfyoung added 2/3 Compat and removed API Design Bug labels Aug 10, 2017

gfyoung reviewed Aug 10, 2017

View reviewed changes

tacaswell force-pushed the fix_items_everywhere branch from 145df9e to 47947db Compare August 10, 2017 16:21

gfyoung reviewed Aug 10, 2017

View reviewed changes

tacaswell force-pushed the fix_items_everywhere branch from 9506454 to 4a4ddcb Compare August 10, 2017 20:32

jreback added this to the 0.21.0 milestone Aug 17, 2017

jreback requested changes Aug 17, 2017

View reviewed changes

tacaswell added 4 commits August 19, 2017 14:33

TST: extend test and add issue reference

764cf55

DOC: add whatsnew entry

b1f46f8

DOC/TST: trivial changes

32aa089

tacaswell force-pushed the fix_items_everywhere branch from 4a4ddcb to 6c34f6b Compare August 19, 2017 18:35

FIX: support lazy items on Series in all versions of python

b8a9ab7

tacaswell force-pushed the fix_items_everywhere branch from 6c34f6b to b8a9ab7 Compare August 19, 2017 20:36

jreback approved these changes Aug 19, 2017

View reviewed changes

jreback merged commit 3b02e73 into pandas-dev:master Aug 19, 2017

tacaswell deleted the fix_items_everywhere branch August 19, 2017 22:02

jowens pushed a commit to jowens/pandas that referenced this pull request Sep 20, 2017

FIX: define DataFrame.items for all versions of python (pandas-dev#…

db11418

…17214)

TomAugspurger mentioned this pull request Sep 25, 2017

'Series' object has no attribute 'items' on Python 2.7 #17671

Closed

mivade added a commit to pennmem/bptools that referenced this pull request Sep 25, 2017

Address Series.items not existing on Python 2.7

4671c93

See pandas-dev/pandas#17214

alanbato pushed a commit to alanbato/pandas that referenced this pull request Nov 10, 2017

FIX: define DataFrame.items for all versions of python (pandas-dev#…

fcd642f

…17214)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

FIX: define `DataFrame.items` for all versions of python #17214

FIX: define `DataFrame.items` for all versions of python #17214

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FIX: define DataFrame.items for all versions of python #17214

FIX: define DataFrame.items for all versions of python #17214

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FIX: define `DataFrame.items` for all versions of python #17214

FIX: define `DataFrame.items` for all versions of python #17214