CLN: clean up parser options #5121
Merged
+53
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a test to make sure that the C parser options validation is actually covered
Contributor
|
Great work catching this! 👍 |
Member
Author
|
i'm not sure about this factorize argument ... now that i think about it i think it hsould be removed from the signature and set of arguments that are incompatible with the python parser |
Member
Author
Contributor
|
seems fine, any idea what factorize does? |
Member
Author
|
nothing. wasn't used anywhere in |
Member
Author
|
looks like it was added as an option in c4d36ca and has just been floating around since then doing nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a test to make sure that the C parser options validation is actually
covered
example travis fail:
https://travis-ci.org/pydata/pandas/jobs/12171563
explanation (for the record):
if you print out
optionsbefore this commit you'll see that they are all overwritten with a single value. Whatever this value is will depend on how the_parser_defaultsdictionary happens to be ordered (which is random because of hashing).This caused a bug because the value of
valueis retained from the loop over_parser_defaults, anddefaultis not reassigned in the two loops that follow the loop over_parser_defaults, so all the values end up being the same as the last argument that was iterated over from_parser_defaults.magic explained 🎉