BUG/REF: Use lru_cache instead of NUMBA_FUNC_CACHE #46086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Feb 26, 2022
Contributor
There was a problem hiding this comment.
assume this has neutral perf impact
pandas/core/groupby/groupby.py
Outdated
| starts, ends, sorted_index, sorted_data = self._numba_prep(df) | ||
| aggregator = executor.generate_shared_aggregator( | ||
| func, engine_kwargs, numba_cache_key_str | ||
| func, *get_jit_arguments(engine_kwargs) |
Contributor
There was a problem hiding this comment.
can we change get_jit_argument to return a dict and splat here? e.g. always keyword args
Member
Author
Yup, additionally this actually reduces some unnecessary jitting when e.g. going from |
jreback
approved these changes
Feb 27, 2022
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.5.0.rstfile if fixing a bug or adding a new feature.