10BC0 BUG: fill_value is ignored when reindexing empty series by immerrr · Pull Request #4346 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: fill_value is ignored when reindexing empty series #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
immerrr wants to merge 2 commits into from
Closed

BUG: fill_value is ignored when reindexing empty series #4346

immerrr wants to merge 2 commits into from

Conversation

@immerrr
Copy link
Contributor
@immerrr immerrr commented Jul 24, 2013

Here's a snippet depicting the, probably, buggy behaviour:

>>> import pandas as pd
>>> s = pd.Series()
>>> s.reindex([1,2,3])
1   NaN
2   NaN
3   NaN
dtype: float64
>>> s.reindex([1,2,3], fill_value=0.0)
1   NaN
2   NaN
3   NaN
dtype: float64
>>> pd.version.version
'0.12.0.dev-d7c6eb1'

I'd expect the last output to contain 0.0 values instead of NaN.

@jreback
Copy link
Contributor
jreback commented Jul 24, 2013

pls add a release notes entry as well..thanks

@immerrr
Copy link
Contributor Author
immerrr commented Jul 25, 2013

Done (also rebased the PR against post-0.12.0 master)

@jreback
Copy link
Contributor
jreback commented Aug 23, 2013

@immerr this works in master now

but would like to have your tests in any event

can you rebase and change so just your tests are in?

@jreback
Copy link
Contributor
jreback commented Sep 24, 2013

closed via cef13db

@jreback jreback closed this Sep 24, 2013
@jreback
Copy link
Contributor
jreback commented Sep 24, 2013

@immerrr thanks!

625A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.13

Development

Successfully merging this pull request may close these issues.

2 participants

@immerrr @jreback
0