10BC0 BUG: partial-timestamp slicing near the end of year/quarter/month by jbrockmendel · Pull Request #31064 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: partial-timestamp slicing near the end of year/quarter/month #31064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Jan 18, 2020
Merged

BUG: partial-timestamp slicing near the end of year/quarter/month #31064

jreback merged 2 commits into from
Jan 18, 2020

Conversation

@jbrockmendel
Copy link
Member
@jbrockmendel jbrockmendel commented Jan 16, 2020

I'm fairly confident we can refactor this to be a lot less verbose, but will do that separately from the bugfix.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

WillAyd
WillAyd approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member
@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WillAyd WillAyd added the Timedelta Timedelta data type label Jan 16, 2020
@jbrockmendel jbrockmendel added the Indexing Related to indexing on series/frames, not to indexes themselves label Jan 17, 2020
@jreback jreback added this to the 1.1 milestone Jan 18, 2020
jreback
jreback approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor
@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@jreback jreback merged commit 65b23c2 into pandas-dev:master Jan 18, 2020
@jbrockmendel jbrockmendel deleted the ref-string_slicing branch January 18, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Timedelta Timedelta data type

Projects

None yet

Milestone

1.1

Development

Successfully merging this pull request may close these issues.

3 participants

@jbrockmendel @WillAyd @jreback
0