8000 CLN: de-privatize _parsers and _engines in pandas/core/computation and rename to something more descriptive · Issue #30681 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CLN: de-privatize _parsers and _engines in pandas/core/computation and rename to something more descriptive #30681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hwalinga opened this issue Jan 4, 2020 · 3 comments
Closed

CLN: de-privatize _parsers and _engines in pandas/core/computation and rename to something more descriptive #30681

hwalinga opened this issue Jan 4, 2020 · 3 comments
Labels
Refactor Internal refactoring of code

Comments

@hwalinga
Copy link
Contributor
hwalinga commented Jan 4, 2020

As a followup from #28215

_parsers and _engines as used in the code for the .query and .eval methods should be de-privatized and named to something more informative.

_engines: Dict[str, Type[AbstractEngine]] = {
    "numexpr": NumExprEngine,
    "python": PythonEngine,
}

_parsers = {"python": PythonExprVisitor, "pandas": PandasExprVisitor}

@jreback
@hwalinga hwalinga mentioned this issue Jan 4, 2020
Merged
5 tasks
@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label Apr 1, 2020
@jbrockmendel
Copy link
Member

theres are now ENGINES and PARSERS i think

@hwalinga
Copy link
Contributor Author

Correct. Well I guess this can be closes then!

I also wouldn't think what a better name for those would be. I think only parser was a bit too generic term. Maybe ENGINE_PARSERS, AST_VISITOR?

ENGINES is probably good. What do you think?

@jbrockmendel
Copy link
Member

These are pretty deeply internal, i wouldnt worry about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbrockmendel @hwalinga
0