8000 ENH: Series.append now has ignore_index kw by sinhrks · Pull Request #13677 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@sinhrks
Copy link
Member
@sinhrks sinhrks commented Jul 16, 2016
  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

not sure if there is any reason we haven't supported...

@sinhrks sinhrks added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Enhancement labels Jul 16, 2016
@sinhrks sinhrks added this to the 0.19.0 milestone Jul 16, 2016
@codecov-io
Copy link
codecov-io commented Jul 16, 2016

Current coverage is 84.38%

Merging #13677 into master will not change coverage

@@             master     #13677   diff @@
==========================================
  Files           142        142          
  Lines         51223      51223          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43224      43224          
  Misses         7999       7999          
  Partials          0          0          

Powered by Codecov. Last updated by 6b9cd15...4bc7b54

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a simultaneous example with pd.concat (same results)

@jreback
Copy link
Contributor
jreback commented Jul 18, 2016

lgtm. just minor test comment.

@sinhrks
Copy link
Member Author
sinhrks commented Jul 19, 2016

updated test, and now green.

@jreback jreback closed this in 694fe61 Jul 19, 2016
@jreback
Copy link
Contributor
jreback commented Jul 19, 2016

thanks!

@sinhrks sinhrks deleted the append_series branch July 19, 2016 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0