Basic RST -> Markdown #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgeiger
reviewed
May 12, 2018
pyls/plugins/hover.py
Outdated
| return {'contents': _utils.format_docstring(definitions[0].docstring()) or ""} | ||
| md_docstring = _utils.format_docstring(definitions[0].docstring()) | ||
| return {'contents': { | ||
| 'type': lsp.MarkupKind.Markdown, |
There was a problem hiding this comment.
According to the spec the this should be 'kind': lsp.MarkupKind.Markdown instead of 'type': lsp.MarkupKind.Markdown since hover requests return a MarkupContent object:
export interface MarkupContent {
/**
* The type of the Markup
*/
kind: MarkupKind;
/**
* The content itself
*/
value: string;
}|
And that’ll be why I’ve seen no marked improvement in VSCode!! Thanks for pointing that out. I also note that docutils exists in Python, so we might want to make use of its RST parser instead of replicating the jacket typescript one in the VSCode plugin. |
…-server into ngates/markdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #291