Merge pull request msgpack#125 from bwesterb/master

methane · methane · commit 3f5e0582648b · 2015-01-27T14:03:30.000+09:00
Rollback to correct position in the case of OutOfData. Fixes msgpack#124
diff --git a/msgpack/fallback.py b/msgpack/fallback.py
@@ -195,6 +195,9 @@ def __init__(self, file_like=None, read_size=0, use_list=True,
         # the buffer is not "consumed" completely, for efficiency sake.
         # Instead, it is done sloppily.  To make sure we raise BufferFull at
         # the correct moments, we have to keep track of how sloppy we were.
+        # Furthermore, when the buffer is incomplete (that is: in the case
+        # we raise an OutOfData) we need to rollback the buffer to the correct
+        # state, which _fb_slopiness records.
         self._fb_sloppiness = 0
         self._max_buffer_size = max_buffer_size or 2**31-1
         if read_size > self._max_buffer_size:
@@ -283,7 +286,7 @@ def read_bytes(self, n):
 
     def _fb_rollback(self):
         self._fb_buf_i = 0
-        self._fb_buf_o = 0
+        self._fb_buf_o = self._fb_sloppiness
 
     def _fb_get_extradata(self):
         bufs = self._fb_buffers[self._fb_buf_i:]
diff --git a/test/test_sequnpack.py b/test/test_sequnpack.py
@@ -84,3 +84,15 @@ def test_readbytes():
     assert unpacker.read_bytes(3) == b'oob'
     assert unpacker.unpack() == ord(b'a')
     assert unpacker.unpack() == ord(b'r')
+
+def test_issue124():
+    unpacker = Unpacker()
+    unpacker.feed(b'\xa1?\xa1!')
+    assert tuple(unpacker) == (b'?', b'!')
+    assert tuple(unpacker) == ()
+    unpacker.feed(b"\xa1?\xa1")
+    assert tuple(unpacker) == (b'?',)
+    assert tuple(unpacker) == ()
+    unpacker.feed(b"!")
+    assert tuple(unpacker) == (b'!',)
+    assert tuple(unpacker) == ()
