feature symfony#18728 deprecate get() for uncompiled container builders (xabbuh)

fabpot · fabpot · commit b8ad2bcdb432 · 2016-06-08T13:34:19.000+02:00
This PR was squashed before being merged into the 3.2-dev branch (closes symfony#18728). Discussion ---------- deprecate get() for uncompiled container builders | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | symfony#18673 (comment) | License | MIT | Doc PR | Commits ------- f2e35cb deprecate get() for uncompiled container builders
diff --git a/Tests/DependencyInjection/WebProfilerExtensionTest.php b/Tests/DependencyInjection/WebProfilerExtensionTest.php
@@ -96,11 +96,11 @@ public function testToolbarConfig($toolbarEnabled, $interceptRedirects, $listene
 
         $this->assertSame($listenerInjected, $this->container->has('web_profiler.debug_toolbar'));
 
+        $this->assertSaneContainer($this->getDumpedContainer());
+
         if ($listenerInjected) {
             $this->assertSame($listenerEnabled, $this->container->get('web_profiler.debug_toolbar')->isEnabled());
         }
-
-        $this->assertSaneContainer($this->getDumpedContainer());
     }
 
     public function getDebugModes()

Original file line number	Diff line number	Diff line change
`@@ -96,11 +96,11 @@ public function testToolbarConfig($toolbarEnabled, $interceptRedirects, $listene`
`96`	`96`
`97`	`97`	`$this->assertSame($listenerInjected, $this->container->has('web_profiler.debug_toolbar'));`
`98`	`98`
	`99`	`+ $this->assertSaneContainer($this->getDumpedContainer());`
	`100`	`+`
`99`	`101`	`if ($listenerInjected) {`
`100`	`102`	`$this->assertSame($listenerEnabled, $this->container->get('web_profiler.debug_toolbar')->isEnabled());`
`101`	`103`	`}`
`102`		`-`
`103`		`- $this->assertSaneContainer($this->getDumpedContainer());`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`public function getDebugModes()`