Merge pull request msgpack#46 from alex/patch-1

methane · methane · commit 1532eaa68424 · 2013-02-16T16:34:34.000-08:00
On PyPy, preallocate lists
diff --git a/msgpack/fallback.py b/msgpack/fallback.py
@@ -22,6 +22,7 @@ def dict_iteritems(d):
 if hasattr(sys, 'pypy_version_info'):
     # cStringIO is slow on PyPy, StringIO is faster.  However: PyPy's own
     # StringBuilder is fastest.
+    from __pypy__ import newlist_hint
     from __pypy__.builders import StringBuilder
     USING_STRINGBUILDER = True
     class StringIO(object):
@@ -38,6 +39,7 @@ def getvalue(self):
 else:
     USING_STRINGBUILDER = False
     from io import BytesIO as StringIO
+    newlist_hint = lambda size: []
 
 from msgpack.exceptions import (
         BufferFull,
@@ -346,7 +348,7 @@ def _fb_unpack(self, execute=EX_CONSTRUCT, write_bytes=None):
                     # TODO check whether we need to call `list_hook`
                     self._fb_unpack(EX_SKIP, write_bytes)
                 return
-            ret = []
+            ret = newlist_hint(n)
             for i in xrange(n):
                 ret.append(self._fb_unpack(EX_CONSTRUCT, write_bytes))
             if self._list_hook is not None:
