ppai/timeseries-classification: use check_call instead of run (GoogleCloudPlatform#7180)

davidcavazos · web-flow · commit c7b931e0e248 · 2021-12-01T15:36:07.000-08:00
diff --git a/people-and-planet-ai/timeseries-classification/e2e_test.py b/people-and-planet-ai/timeseries-classification/e2e_test.py
@@ -106,7 +106,7 @@ def raw_labels_dir(bucket_name: str) -> str:
 def container_image() -> str:
     # https://cloud.google.com/sdk/gcloud/reference/builds/submit
     container_image = f"gcr.io/{PROJECT}/{NAME}:{UUID}"
-    subprocess.run(
+    subprocess.check_call(
         [
             "gcloud",
             "builds",
@@ -116,15 +116,14 @@ def container_image() -> str:
             "--machine-type=e2-highcpu-8",
             "--timeout=15m",
             "--quiet",
-        ],
-        check=True,
+        ]
     )
 
     logging.info(f"container_image: {container_image}")
     yield container_image
 
     # https://cloud.google.com/sdk/gcloud/reference/container/images/delete
-    subprocess.run(
+    subprocess.check_call(
         [
             "gcloud",
             "container",
@@ -134,16 +133,15 @@ def container_image() -> str:
             f"--project={PROJECT}",
             "--force-delete-tags",
             "--quiet",
-        ],
-        check=True,
+        ]
     )
 
 
 @pytest.fixture(scope="session")
 def service_url(bucket_name: str, container_image: str) -> str:
     # https://cloud.google.com/sdk/gcloud/reference/run/deploy
     service_name = f"{NAME.replace('/', '-')}-{UUID}"
-    subprocess.run(
+    subprocess.check_call(
         [
             "gcloud",
             "run",
@@ -161,8 +159,7 @@ def service_url(bucket_name: str, container_image: str) -> str:
             f"--set-env-vars=REGION={REGION}",
             f"--set-env-vars=CONTAINER_IMAGE={container_image}",
             "--no-allow-unauthenticated",
-        ],
-        check=True,
+        ]
     )
 
     # https://cloud.google.com/sdk/gcloud/reference/run/services/describe
@@ -189,7 +186,7 @@ def service_url(bucket_name: str, container_image: str) -> str:
     yield service_url
 
     # https://cloud.google.com/sdk/gcloud/reference/run/services/delete
-    subprocess.run(
+    subprocess.check_call(
         [
             "gcloud",
             "run",
@@ -200,8 +197,7 @@ def service_url(bucket_name: str, container_image: str) -> str:
             f"--project={PROJECT}",
             f"--region={REGION}",
             "--quiet",
-        ],
-        check=True,
+        ]
     )
 
 
