Week Two: Copilot Code Review [Copilot Skills Challenge] #185754
Replies: 3 comments 4 replies
-
|
Anyone else encountered a discrepancy in According to Perplexity: "The reason the merge is not blocked is that GitHub’s 'Require conversation resolution before merging' only evaluates conversations created as part of reviews that count toward required reviews, and Copilot’s review does not count because the app does not have write access and is explicitly excluded from mergeability checks ('Only reviews by reviewers with write access count toward mergeability')". I tried adding a comment under Copilot review is unresolved and the PR can be merged
|
Beta Was this translation helpful? Give feedback.
-
|
Hello @ijklim, thanks for reporting this! 🧑🚀 I've created an issue on the exercise repo. At the moment, I am pretty busy, but I will do a test run of the exercise again (hopefully this week) and look for adjustments to be made. Thanks again! |
Beta Was this translation helpful? Give feedback.
-
|
This can be fixed with stricter rulesets / branch protection rules as a workaround in real projects. You can find the settings here or do this through code, |
Beta Was this translation helpful? Give feedback.
-
|
hah, this took me way too long to track down... the exercise is specifically looking for a ruleset name, pretty annoying and not a great way to check for rulesets. Also, I ended up tracking down the dude Grant Birki because his name is in a lot of github actions supply-chains and wanted to verify this wasn't a security risk. *He used to work for github, still seems like it shouldn't be in a private repo, but less concerning. |
Beta Was this translation helpful? Give feedback.
-
|
Step 2) dcbdb * I think some are up for interpretation depending on the scenario (solo project vs open-source). |
Beta Was this translation helpful? Give feedback.
-
|
Missed Week 1? Check that out here! Week One: Customize Your GitHub Copilot Experience [Copilot Skills Challenge] |
Beta Was this translation helpful? Give feedback.
-
|
Step 2) dcbab |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Welcome to part two of the GitHub Copilot Skills Series! This week, we’ll leverage GitHub Copilot code review to promote code quality and catch issues before they reach production.
Missed last week? Head to Part One and then join us back here.
Step One: Skills Exercise 💪
To begin, complete the GitHub Copilot Code Review exercise where you’ll learn how to use GitHub Copilot for automated code reviews, customize review criteria, and set up automatic reviews
Then, come back for part two to deepen your learning with our challenge and be entered to win a GitHub Shop Voucher!
Step Two: Community Challenge 🧠
Answer these multiple choice questions in the comments section:
Question One: Which Copilot feature can assist you in writing clearer code review comments?
a) Suggest code comments
b) Generate docstrings
c) Suggest edits and questions based on the changed code
d) All of the above
Question Two: Copilot suggests a significant refactor to a core function, affecting its inputs and outputs in ways not documented in the original pull request. What actions should you take as a reviewer?
a) Carefully review the Copilot-suggested changes, and if the implementation appears sound, approve and merge the pull request; leave it to future contributors to update related documentation or tests as needed.
b) Schedule a meeting with the author to discuss the refactor and its broader implications; wait for input from other team members before making any review decisions.
c) Review the Copilot-generated changes in detail, assess their impact on related code, and raise questions with the author about compatibility, documentation, and test coverage; recommend updating documentation or tests within the PR before approving.
d) Comment on the refactor, recommending the author revert to the original function structure unless the changes are justified with benchmarking data or formal design approval, then proceed only if those are provided.
Question Three: Copilot generates a code comment suggesting error handling for a function that currently has none. What should you do with this suggestion?
a) Ignore the comment since the function already works as intended
b) Share the suggestion with the author, and ask them to consider adding appropriate error handling
c) Automatically add error handling as suggested without involving the author
d) Remove the suggestion if it wasn’t part of the author’s original changes
Question Four: When using Copilot to add code review comments, what is the best way to ensure your feedback is helpful to the contributor?
a) Phrase suggestions in a respectful, constructive manner, and explain your reasoning
b) Write as many comments as possible to cover all potential issues
c) Use copy-pasted comments for consistency
d) Avoid suggestions unless there is a critical bug
Question Five; When should you rely solely on Copilot-generated review comments without further investigation?
a) Only when the code author is highly experienced
b) Never—Copilot’s suggestions are valuable but should be considered alongside your own analysis
c) Whenever Copilot highlights a possible error
d) Anytime Copilot's comments match your initial impression
We’ll be sharing the answers in the comments on Monday 🧠
Use the discussion below to share additional resources, ask questions for our team to answer, and respond to the challenge.
**No Purchase Necessary. Open only to Github community members 14+. Game ends February 17, 2026. For details, see Official rules.
Beta Was this translation helpful? Give feedback.
All reactions