10000 Add sample running Oracle WLS Kubernetes Operator on Azure Kubernetes Service by edburns · Pull Request #1873 · oracle/weblogic-kubernetes-operator · GitHub
[go: up one dir, main page]
Skip to content

Add sample running Oracle WLS Kubernetes Operator on Azure Kubernetes Service #1873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 20, 2020
Merged

Add sample running Oracle WLS Kubernetes Operator on Azure Kubernetes Service #1873

merged 9 commits into from
Aug 20, 2020

Conversation

edburns
Copy link
Contributor
@edburns edburns commented Aug 15, 2020

Please review

weblogic-kubernetes-operator/docs-source/content/samples/simple/azure-kubernetes-service/_index.md

Tested on AKS.

@edburns edburns mentioned this pull request Aug 15, 2020
Closed
rosemarymarano
rosemarymarano reviewed Aug 17, 2020
View reviewed changes
Copy link
Member
@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits, otherwise good.

@rjeberhard
Copy link
Member

The PR has a non-image binary file. It's the test war: kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/testwebapp.war. I've been working with the understanding that our security rules don't allow a checked-in binary file. Let me double-check that this is still the expectation.

@edburns edburns marked this pull request as draft August 18, 2020 13:23
@edburns
Copy link
Contributor Author
edburns commented Aug 18, 2020

Hello @rjeberhard , because today's changes included a modification to the script to remove the ClusterRoleBinding actions, I converted this to a Draft PR. A Draft PR indicates I am not ready to have this merged. I will test the changes, resolve any issues, and mark it Ready for review as soon as possible.

@rjeberhard
Copy link
Member

Thanks, @edburns. I verified with @markxnelson that it is unfortunately correct that the security policy doesn't let us merge changes with non-image binary files. In other samples, we've included the source for the war rather than the war itself.

@edburns edburns marked this pull request as ready for review August 18, 2020 19:06
@edburns
Copy link
Contributor Author
edburns commented Aug 18, 2020

Hello @rosemarymarano @rjeberhard @jshum2479 , this PR is ready for review.

rosemarymarano
rosemarymarano reviewed Aug 18, 2020
View reviewed changes
Copy link
Member
@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two (very minor) edits, one comment.

@rjeberhard rjeberhard requested a review from mriccell August 19, 2020 14:05
@edburns edburns marked this pull request as draft August 19, 2020 18:16
@edburns
Copy link
8000
Contributor Author
edburns commented Aug 20, 2020

Added clean up section and fixed changes suggested by @rosemarymarano . Ready for review again.

@edburns edburns marked this pull request as ready for review August 20, 2020 04:53
@edburns
Copy link
Contributor Author
edburns commented Aug 20, 2020

@mriccell may I please kindly have your +1 on this, or let me know what I must change to earn it?

mriccell
mriccell requested changes Aug 20, 2020
View reviewed changes
edburns and others added 9 commits August 20, 2020 19:01
@edburns
PR to add sample running Oracle WLS Kubernetes Operator on Azure Kube…
0f172a3 
…rnetes Service. Thanks to Johnny Shum, Ryan Eberhart and Monica Ricelli.

Merge from branch created for #1804

Update _index.md

On branch edburns-msft-180-01-wls-aks
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Version numbers in prerequisites.

- Additional "Successful output looks like" blocks.

- When a code block defines an env var, export it.

- Before running the script to create the yaml, rm -rf ~/azure.

modified:   kubernetes/samples/scripts/create-kuberetes-secrets/create-azure-storage-credentials-secret.sh
modified:   kubernetes/samples/scripts/create-kuberetes-secrets/create-docker-credentials-secret.sh

- chmod ugo+x

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml

- Readability.

- Move the "prefix" stuff to the "must change" section.

On branch edburns-msft-180-01-wls-aks
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Working toward 1163875 Apply disambiguation prefix on additional items.

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

- Correct spelling error in comment.

Task 1163875: Apply disambiguation prefix on additional items

Changes after reviewing commit 705ab33 with Ed.

Fix check points and check length of namePrefix.

Create validate.sh to validate resources before creating domain manually.

Typos

On branch edburns-msft-180-01-wls-aks typos
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

On branch edburns-msft-180-01-wls-aks
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Spelling.

- Additional validation: kubectl logs -f.

- Mention health checks.

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

- Make it so the script can be run from an absolute path.

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh

- chmod ugo+x

Modified in kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml
Update _index.md and all related samples script and yaml files to remove all mention of Docker Hub

Modified in kubernetes/samples/scripts/create-kuberetes-secrets/create-docker-credentials-secret.sh
Update dockerServer=container-registry.oracle.com

On branch edburns-msft-180-01-wls-aks
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Fix link to GET IMAGES.

- Fix lower case l.

- Update heading.

- Correct wording.

- Give hint about ImagePullBackoff.

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml

- Adjust comments to make it clear that it's Oracle SSO credentials.

modified:   kubernetes/samples/scripts/create-weblogic-domain/domain-home-on-pv/create-domain.sh

- Increased retries to 30.

On branch edburns-msft-180-01-wls-aks
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pv-template.yaml
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pvc-template.yaml

- Changes suggested by Johnny Shum to get past the cluster distribution problem.

Revert "On branch edburns-msft-180-01-wls-aks"

This reverts commit b52b466.

Name vp/pvc, file share with unique name.

Add testwebapp.war for testing.

Modified in kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
Change file share name with "prefix-weblogic-time"
Change pv, pvc name with "prefix-azurefile-time"
Output status during waiting for job completed.

Modified in docs-source/content/samples/simple/azure-kubernetes-service/_index.md
Update text with pv/pvc, file share unique name.

Modified in kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml
Change name structure of pvc and file share.

Modified in kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/validate.sh
Fix validate.sh with pv/pvc, file share unique name.

On branch edburns-msft-180-02-wls-aks forward slashes only.
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

On branch edburns-msft-180-02-wls-aks Verified manual execution of steps works on Oracle Enterprise Java subscription.
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pv-template.yaml
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/azure-file-pvc-template.yaml

- increase capacity to 10Gi.

- Set on pv:

   ```
   persistentVolumeReclaimPolicy: Retain
   ```

- Remove nobrl.

- Set on pvc:

+  selector:
+    matchLabels:
+      usage: %PERSISTENT_VOLUME_CLAIM_NAME%

On branch edburns-msft-180-02-wls-aks In table for automation, update description for docker related parameters.
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md
@edburns
Update _index.md
539900f 
Address comments from @rosemarymarano.
@edburns
Update README.md
1ba54bd 
Address @rosemarymarano comment.
@edburns
Update _index.md
fd865c7
@edburns
On branch edburns-msft-180-02-wls-aks
6bca6ee 
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Copyedits.

- Remove ClusterRoleBinding

modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh

- Remove ClusterRoleBinding
@edburns
On branch edburns-msft-180-02-wls-aks
b87d380 
deleted:    kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/testwebapp.war

- "security policy doesn't let us merge changes with non-image binary files."

- This deleted file has the same checksum as `kubernetes/samples/charts/application/testwebapp.war` so let's just use that.

modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md

- Use `kubernetes/samples/charts/application/testwebapp.war`
@edburns
Change default VMSize and node number, as Standard_D4s_v3 and 3 node …
2f34995 
…exceed quota on free azure account.

Modified on docs-source/content/samples/simple/azure-kubernetes-service/_index.md
Change VM size to Standard_D4s_v3 and node number to 2 in document.

Modified in kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks-inputs.yaml
Change default value of VM size to Standard_D4s_v3 and node number to 2.

Tested in Oracle Enterprise Java and a free azure account.
@edburns
On branch edburns-msft-180-02-wls-aks Add Clean Up section.
28d7e2b 
modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
@edburns
On branch edburns-msft-180-02-wls-aks Apply changes suggested by @mri…
39ed467 
…ccell.

modified:   docs-source/content/samples/simple/azure-kubernetes-service/_index.md
modified:   kubernetes/samples/scripts/create-weblogic-domain-on-azure-kubernetes-service/create-domain-on-aks.sh
@edburns
Copy link
Contributor Author
edburns commented Aug 20, 2020

Hello @mriccell , 39ed467 has your requested changes.

mriccell
mriccell approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member
@mriccell mriccell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution this is a very nice sample!
Monica

@mriccell mriccell merged commit e505556 into oracle:develop Aug 20, 2020
rjeberhard pushed a commit that referenced this pull request Sep 1, 2020
@mriccell @rjeberhard
Merge pull request #1873 from edburns/edburns-msft-180-02-wls-aks
5ef9edf 
Add sample running Oracle WLS Kubernetes Operator on Azure Kubernetes Service
@rjeberhard rjeberhard mentioned this pull request Sep 1, 2020
Merged
rjeberhard added a commit that referenced this pull request Sep 2, 2020
@rjeberhard @mriccell
Merge pull request #1873 from edburns/edburns-msft-180-02-wls-aks (#1894
def64b8 
)

Add sample running Oracle WLS Kubernetes Operator on Azure Kubernetes Service

Co-authored-by: Monica Riccelli <monica.riccelli@oracle.com>
@edburns edburns deleted the edburns-msft-180-02-wls-aks branch September 22, 2020 03:16
@edburns edburns mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mriccell mriccell mriccell approved these changes

@jshum2479 jshum2479 jshum2479 approved these changes

@rjeberhard rjeberhard rjeberhard approved these changes

@rosemarymarano rosemarymarano rosemarymarano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edburns @rjeberhard @mriccell @jshum2479 @rosemarymarano
0