From 49bdc1c56e87204848e1dd88d6735180f0a86d0d Mon Sep 17 00:00:00 2001 From: Matjaz Pirnovar Date: Mon, 25 Sep 2023 10:21:06 -0700 Subject: [PATCH 1/5] Update http_project_config_manager.rb Add soft warning that polling interval under 30 s is not recommended. --- .../config_manager/http_project_config_manager.rb | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/lib/optimizely/config_manager/http_project_config_manager.rb b/lib/optimizely/config_manager/http_project_config_manager.rb index 0da73c1f..4cc2fad3 100644 --- a/lib/optimizely/config_manager/http_project_config_manager.rb +++ b/lib/optimizely/config_manager/http_project_config_manager.rb @@ -268,6 +268,13 @@ def polling_interval(polling_interval) return end + unless polling_interval.positive? && polling_interval < 30 + @logger.log( + Logger::WARNING, + "Polling intervals below 30 seconds are not recommended." + ) + end + @polling_interval = polling_interval end From 53fffd083afde072701f18e17c38e814241ae8c3 Mon Sep 17 00:00:00 2001 From: Matjaz Pirnovar Date: Mon, 25 Sep 2023 10:29:50 -0700 Subject: [PATCH 2/5] Update w single quotes --- lib/optimizely/config_manager/http_project_config_manager.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optimizely/config_manager/http_project_config_manager.rb b/lib/optimizely/config_manager/http_project_config_manager.rb index 4cc2fad3..446226f7 100644 --- a/lib/optimizely/config_manager/http_project_config_manager.rb +++ b/lib/optimizely/config_manager/http_project_config_manager.rb @@ -271,7 +271,7 @@ def polling_interval(polling_interval) unless polling_interval.positive? && polling_interval < 30 @logger.log( Logger::WARNING, - "Polling intervals below 30 seconds are not recommended." + 'Polling intervals below 30 seconds are not recommended.' ) end From 703b19fb414c9143b2bc848e65c7ba341c1c7f86 Mon Sep 17 00:00:00 2001 From: Matjaz Pirnovar Date: Mon, 25 Sep 2023 10:47:07 -0700 Subject: [PATCH 3/5] Update http_project_config_manager.rb --- lib/optimizely/config_manager/http_project_config_manager.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optimizely/config_manager/http_project_config_manager.rb b/lib/optimizely/config_manager/http_project_config_manager.rb index 446226f7..662b4c64 100644 --- a/lib/optimizely/config_manager/http_project_config_manager.rb +++ b/lib/optimizely/config_manager/http_project_config_manager.rb @@ -274,7 +274,7 @@ def polling_interval(polling_interval) 'Polling intervals below 30 seconds are not recommended.' ) end - + @polling_interval = polling_interval end From cd2228d3525abaf74d85a05f1c1fc402c32020a8 Mon Sep 17 00:00:00 2001 From: Matjaz Pirnovar Date: Mon, 25 Sep 2023 10:50:50 -0700 Subject: [PATCH 4/5] Update WARNING to WARN --- lib/optimizely/config_manager/http_project_config_manager.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optimizely/config_manager/http_project_config_manager.rb b/lib/optimizely/config_manager/http_project_config_manager.rb index 662b4c64..15cfcf61 100644 --- a/lib/optimizely/config_manager/http_project_config_manager.rb +++ b/lib/optimizely/config_manager/http_project_config_manager.rb @@ -270,7 +270,7 @@ def polling_interval(polling_interval) unless polling_interval.positive? && polling_interval < 30 @logger.log( - Logger::WARNING, + Logger::WARN, 'Polling intervals below 30 seconds are not recommended.' ) end From 7975e9d99670b27e3197532f7eb57fb42283c51f Mon Sep 17 00:00:00 2001 From: Matjaz Pirnovar Date: Mon, 25 Sep 2023 12:56:50 -0700 Subject: [PATCH 5/5] Update lib/optimizely/config_manager/http_project_config_manager.rb Co-authored-by: Andy Leap <104936100+andrewleap-optimizely@users.noreply.github.com> --- lib/optimizely/config_manager/http_project_config_manager.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/optimizely/config_manager/http_project_config_manager.rb b/lib/optimizely/config_manager/http_project_config_manager.rb index 15cfcf61..91610455 100644 --- a/lib/optimizely/config_manager/http_project_config_manager.rb +++ b/lib/optimizely/config_manager/http_project_config_manager.rb @@ -268,7 +268,7 @@ def polling_interval(polling_interval) return end - unless polling_interval.positive? && polling_interval < 30 + if polling_interval < 30 @logger.log( Logger::WARN, 'Polling intervals below 30 seconds are not recommended.'