8000 [OASIS-6102]: changed functionality of the JSON schema validator module by yavorona · Pull Request #438 · optimizely/javascript-sdk · GitHub
[go: up one dir, main page]
Skip to content

[OASIS-6102]: changed functionality of the JSON schema validator module #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 3, 2020
Merged

[OASIS-6102]: changed functionality of the JSON schema validator module #438

merged 7 commits into from
Apr 3, 2020

Conversation

yavorona
Copy link
Contributor
@yavorona yavorona commented Apr 2, 2020

Summary

  • Changed functionality of the JSON schema validator module to only validate against projectConfigSchema
  • Updated existing unit tests to reflect this change

Test plan

Existing unit tests

Issues

OASIS-6102

yavorona added 4 commits April 1, 2020 19:16
@yavorona
Summary:
fdfb0bc 
 - Changed validate method to except jsonObject only in json_schema_validator/index.js
Test:
 - Updated test to pass
@yavorona
Address Matt's comments
452252b
@yavorona
Eliminate extraneous spaces
53a693b
@yavorona
Remove unnecessary imports
1bcf039
@yavorona yavorona requested a review from a team as a code owner April 2, 2020 02:21
@yavorona yavorona mentioned this pull request Apr 2, 2020
Closed
@coveralls
Copy link
coveralls commented Apr 2, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.003%) to 97.223% when pulling cee4e30 on pnguen/OASIS-6102 into a49d323 on master.

@mjc1283 mjc1283 self-requested a review April 2, 2020 16:54
@mikeproeng37
Copy link
Contributor

@yavorona we should also include a section on the readme to explain when/how to use the jsonSchemaValidator --> users should include in their config only if they are not using our project config manager and are using a datafile that has been modified.

@yavorona
Copy link
Contributor Author
yavorona commented Apr 2, 2020

Talked offline with @mikeng13 and decided to document this in our developer docs instead.

1 similar comment
@yavorona
Copy link
Contributor Author
yavorona commented Apr 2, 2020

Talked offline with @mikeng13 and decided to document this in our developer docs instead.

@mjc1283
Copy link
Contributor
mjc1283 commented Apr 2, 2020

@mikeng13 This PR shouldn't have any impact on users, it's just a refactor that removes the project config schema from being pulled into the browser bundle. Let me know if I overlooked something that needs to be documented or updated in docs.

@mikeproeng37
Copy link
Contributor

@mikeng13 This PR shouldn't have any impact on users, it's just a refactor that removes the project config schema from being pulled into the browser bundle. Let me know if I overlooked something that needs to be documented or updated in docs.

You are right. Looks like we already don't bring in the validator in the browser bundle and instead are removing the schema from the project config. SGTM

@mjc1283 mjc1283 merged commit 23988b1 into master Apr 3, 2020
@mjc1283 mjc1283 deleted the pnguen/OASIS-6102 branch April 3, 2020 18:25
jasonkarns added a commit to github/optimizely-javascript-sdk that referenced this pull request May 12, 2020
@jasonkarns
Merge branch 'v4' into github
94094fd 
* v4:
  test suite doesn't pass cleanly
  prepare already runs build
  v4.0.0-github.0
  Ignore package tarballs
  Resume building non-minified ES entrypoint
  revert to master
  Expose an ESM-FULL bundle which includes optimizely deps
  Standardize ESM bundle
  Generate both min and non-min esm output
  exports option for es output is redundant. auto is best
  Use rollup --config- options for specifying bundles
  Build-all by default
  build various bundles using --config-* param
  chore: Prepare for 4.0.0 release (optimizely#468)
  fix: Removed React Native client engine temporarily (optimizely#466)
  chore: Prepare for 4.0.0-rc.2 release (optimizely#465)
  chore: Add source maps to build output (optimizely#464)
  fix(project config): Don't mutate the datafile object (optimizely#462)
  chore: Prepare for 4.0.0-rc.1 release (optimizely#461)
  chore: Prepare for js-sdk-datafile-manager 0.5.0 release (optimizely#460)
  chore(datafile manager): Remove react native datafile manager entry from package.json (optimizely#459)
  fix(datafile manager): Node datafile requests use gzip,deflate compression (optimizely#456)
  docs(datafile manager): Removed manual dependency installation requirement from docs (optimizely#457)
  chore(datafile manager): Added async storage as dev dependency (optimizely#455)
  refactor: Added a separate bundle for Json Schema Validator (optimizely#454)
  refactor: Convert lib/utils to ES module (Part 2/2) (optimizely#452)
  refactor: Convert lib/core to ES module (Part 2/2) (optimizely#450)
  chore(datafile manager): Update years in header comments (optimizely#453)
  refactor: Convert lib/core to ES module (Part 1/2) (optimizely#449)
  refactor: Convert lib/utils to ES module (Part 1/2) (optimizely#451)
  refactor: Convert lib/optimizely/* and lib/tests/* to ES module (optimizely#448)
  refactor: Convert lib/plugins from CJS to ES module (optimizely#427)
  chore: Update js-sdk-utils to 0.2.0 (optimizely#447)
  refactor: Convert entry points to es module and create minified bundles (optimizely#445)
  chore: Update CHANGELOG.MD for jsonSchemaValidator change (optimizely#443)
  Change functionality of JSON schema validation by removing skipJSONValidation entirely. Now a user needs to import jsonSchemaValidator from @optimizely/optimizely-sdk/lib/utils/json_schema_validator and pass it to createInstance when validation is desired. (optimizely#442)
  chore(datafile manager): Lint and formatting fixes for datafile manager tests (optimizely#441)
  [OASIS-6102]: changed functionality of the JSON schema validator module (optimizely#438)
  chore(datafile manager): Fix ESLint warnings & errors, apply Prettier formatting (optimizely#440)
  fix (datafile-manager): Fix boolean types, remove StaticDatafileManager, update READMe, add eslint + prettier (optimizely#436)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees

@yavorona yavorona

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yavorona @coveralls @mikeproeng37 @mjc1283
0