From 905c43d311a8e72e582a1f49adb18fd52d2ae4d5 Mon Sep 17 00:00:00 2001
From: fayyazarshad <fayyazarshad@folio3.com>
Date: Thu, 20 Feb 2020 11:24:02 -0800
Subject: [PATCH 1/2] Removed isNumber method of Lodash

---
 packages/optimizely-sdk/lib/utils/fns/index.js  |  4 +++-
 .../optimizely-sdk/lib/utils/fns/index.tests.js | 17 +++++++++++++++++
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
index d066c229d..649477eae 100644
--- a/packages/optimizely-sdk/lib/utils/fns/index.js
+++ b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -34,5 +34,7 @@ module.exports = {
     return uuid.v4();
   },
   values: require('lodash/values'),
-  isNumber: require('lodash/isNumber'),
+  isNumber: function(value) {
+    return typeof value == 'number';
+  },
 };
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.tests.js b/packages/optimizely-sdk/lib/utils/fns/index.tests.js
index b5aaa66c8..735935794 100644
--- a/packages/optimizely-sdk/lib/utils/fns/index.tests.js
+++ b/packages/optimizely-sdk/lib/utils/fns/index.tests.js
@@ -37,5 +37,22 @@ describe('lib/utils/fns', function() {
         assert.isTrue(fns.isFinite(-Math.pow(2, 53)));
       });
     });
+    describe('isNumber', function() {
+      it('should return true in case of number', function() {
+        assert.isTrue(fns.isNumber(3));
+      });
+      it('should return true in case of value from Number object ', function() {
+        assert.isTrue(fns.isNumber(Number.MIN_VALUE));
+      });
+      it('should return true in case of Infinity ', function() {
+        assert.isTrue(fns.isNumber(Infinity));
+      });
+      it('should return false in case of string', function() {
+        assert.isFalse(fns.isNumber('3'));
+      });
+      it('should return false in case of null', function() {
+        assert.isFalse(fns.isNumber(null));
+      });
+    });
   });
 });

From 9aa08c4d6067a3d2b943d7c824016cb78c24156b Mon Sep 17 00:00:00 2001
From: fayyazarshad <fayyazarshad@folio3.com>
Date: Fri, 21 Feb 2020 10:39:08 -0800
Subject: [PATCH 2/2] Added changes upon feedback

---
 packages/optimizely-sdk/lib/utils/fns/index.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
index 649477eae..78912481a 100644
--- a/packages/optimizely-sdk/lib/utils/fns/index.js
+++ b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -35,6 +35,6 @@ module.exports = {
   },
   values: require('lodash/values'),
   isNumber: function(value) {
-    return typeof value == 'number';
+    return typeof value === 'number';
   },
 };