Removing isArray from utils because Array.isArray would be used everywhere

fayyazarshad · fayyazarshad · commit 6ef7ebeb2c90 · 2020-02-21T11:23:12.000-08:00
diff --git a/packages/optimizely-sdk/lib/utils/fns/index.js b/packages/optimizely-sdk/lib/utils/fns/index.js
@@ -24,9 +24,6 @@ module.exports = {
   currentTimestamp: function() {
     return Math.round(new Date().getTime());
   },
-  isArray: function(value) {
-    return Array.isArray(value);
-  },
   isEmpty: require('lodash/isEmpty'),
   isFinite: function(number) {
     return _isFinite(number) && Math.abs(number) <= MAX_NUMBER_LIMIT;
diff --git a/packages/optimizely-sdk/lib/utils/json_schema_validator/index.js b/packages/optimizely-sdk/lib/utils/json_schema_validator/index.js
@@ -40,7 +40,7 @@ module.exports = {
     if (result.valid) {
       return true;
     } else {
-      if (fns.isArray(result.errors)) {
+      if (Array.isArray(result.errors)) {
         throw new Error(sprintf(ERROR_MESSAGES.INVALID_DATAFILE, MODULE_NAME, result.errors[0].property, result.errors[0].message));
       }
       throw new Error(sprintf(ERROR_MESSAGES.INVALID_JSON, MODULE_NAME));

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ module.exports = {`
`40`	`40`	`if (result.valid) {`
`41`	`41`	`return true;`
`42`	`42`	`} else {`
`43`		`- if (fns.isArray(result.errors)) {`
	`43`
`44`	`44`	`throw new Error(sprintf(ERROR_MESSAGES.INVALID_DATAFILE, MODULE_NAME, result.errors[0].property, result.errors[0].message));`
`45`	`45`	`}`
`46`	`46`	`throw new Error(sprintf(ERROR_MESSAGES.INVALID_JSON, MODULE_NAME));`