8000 Add to do and clean up · optimizely/javascript-sdk@408e825 · GitHub
[go: up one dir, main page]

Skip to content

Commit 408e825

Browse files
committed
Add to do and clean up
1 parent 8fb82cd commit 408e825

File tree

1 file changed

+3
-4
lines changed
  • packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator

1 file changed

+3
-4
lines changed

packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.ts

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,14 @@ import {
2323
LOG_MESSAGES,
2424
} from '../../utils/enums';
2525

26-
export type UserAttributes = {
26+
// TODO: Find place for UserAttributes and Condition types to live in
27+
type UserAttributes = {
2728
// TODO[OASIS-6649]: Don't use object type
2829
// eslint-disable-next-line @typescript-eslint/no-explicit-any
2930
[name: string]: any;
3031
};
3132

32-
export type Condition = {
33+
type Condition = {
3334
[name: string]: string;
3435
};
3536

@@ -279,8 +280,6 @@ function lessThanEvaluator(condition: Condition, userAttributes: UserAttributes,
279280
* isn't a string
280281
*/
281282
function substringEvaluator(condition: Condition, userAttributes: UserAttributes, logger: LoggerFacade): boolean | null {
282-
console.log('my condition', condition);
283-
console.log('my userAttributes', userAttributes);
284283
const conditionName = condition.name;
285284
const userValue = userAttributes[condition.name];
286285
const userValueType = typeof userValue;

0 commit comments

Comments
 (0)
0