comments addressed

ozayr-zaviar · ozayr-zaviar · commit 33742ea48f5b · 2022-09-23T21:12:47.000+05:00
diff --git a/packages/optimizely-sdk/karma.base.conf.js b/packages/optimizely-sdk/karma.base.conf.js
@@ -23,7 +23,7 @@ module.exports = {
   plugins: ['karma-mocha', 'karma-webpack', require('karma-browserstack-launcher')],
 
   webpack: {
-    mode:'development',
+    mode:'production',
     module: {
       rules: [
         {
diff --git a/packages/optimizely-sdk/lib/plugins/datafile_manager/browser_http_polling_datafile_manager.ts b/packages/optimizely-sdk/lib/plugins/datafile_manager/browser_http_polling_datafile_manager.ts
@@ -47,4 +47,3 @@
    }
    return new HttpPollingDatafileManager(datafileManagerConfig);
  }
- 
diff --git a/packages/optimizely-sdk/lib/plugins/datafile_manager/http_polling_datafile_manager.tests.js b/packages/optimizely-sdk/lib/plugins/datafile_manager/http_polling_datafile_manager.tests.js
@@ -21,17 +21,8 @@ import datafileManager from '../../modules/datafile-manager/index.node';
 describe('lib/plugins/datafile_manager/http_polling_datafile_manager', function() {
   var sandbox = sinon.sandbox.create();
   
-  beforeEach(() => {    
-    // console.log(datafileManager.HttpPollingDatafileManager, {
-    //   autoUpdate: true,
-    //   datafileAccessToken: 'THE_TOKEN',
-    //   updateInterval: 5000,
-    //   urlTemplate: 'http://example.com',
-    //   sdkKey: 'SDK_KEY',
-    // })    
+  beforeEach(() => {
     sandbox.stub(datafileManager,'HttpPollingDatafileManager')
-    // sandbox.stub(datafileManager.HttpPollingDatafileManager, 'NodeDatafileManager')
-    // sandbox.stub(datafileManager, 'NodeDatafileManager')
   });
 
   afterEach(() => {
diff --git a/packages/optimizely-sdk/lib/plugins/datafile_manager/react_native_http_polling_datafile_manager.ts b/packages/optimizely-sdk/lib/plugins/datafile_manager/react_native_http_polling_datafile_manager.ts
@@ -47,4 +47,3 @@
    }
    return new HttpPollingDatafileManager(datafileManagerConfig);
  }
- 
diff --git a/packages/optimizely-sdk/package-lock.json b/packages/optimizely-sdk/package-lock.json

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ module.exports = {`
`23`	`23`	`plugins: ['karma-mocha', 'karma-webpack', require('karma-browserstack-launcher')],`
`24`	`24`
`25`	`25`	`webpack: {`
`26`		`- mode:'development',`
	`26`	`+ mode:'production',`
`27`	`27`	`module: {`
`28`	`28`	`rules: [`
`29`	`29`	`{`
Original file line number	Diff line number	Diff line change
`@@ -47,4 +47,3 @@`
`47`	`47`	`}`
`48`	`48`	`return new HttpPollingDatafileManager(datafileManagerConfig);`
`49`	`49`	`}`
`50`		`-`