From 0d6976d517e433668eb1a7dd12120f0af9da4b01 Mon Sep 17 00:00:00 2001 From: Vin Halbwachs Date: Wed, 26 Feb 2020 12:23:39 -0500 Subject: [PATCH 1/2] (fix) change log level to warn when experiment not in datafile --- .../java/com/optimizely/ab/config/DatafileProjectConfig.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java b/core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java index ca7f7e5fe..050f57add 100644 --- a/core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java +++ b/core-api/src/main/java/com/optimizely/ab/config/DatafileProjectConfig.java @@ -221,7 +221,7 @@ public Experiment getExperimentForKey(@Nonnull String experimentKey, // if the given experiment key isn't present in the config, log an exception to the error handler if (experiment == null) { String unknownExperimentError = String.format("Experiment \"%s\" is not in the datafile.", experimentKey); - logger.error(unknownExperimentError); + logger.warn(unknownExperimentError); errorHandler.handleError(new UnknownExperimentException(unknownExperimentError)); } @@ -247,7 +247,7 @@ public EventType getEventTypeForName(String eventName, ErrorHandler errorHandler // if the given event name isn't present in the config, log an exception to the error handler if (eventType == null) { String unknownEventTypeError = String.format("Event \"%s\" is not in the datafile.", eventName); - logger.error(unknownEventTypeError); + logger.warn(unknownEventTypeError); errorHandler.handleError(new UnknownEventTypeException(unknownEventTypeError)); } From 0f542684e556673d79d1fd17d102ed93052808b6 Mon Sep 17 00:00:00 2001 From: "alan.hu" Date: Wed, 26 Feb 2020 21:19:06 -0500 Subject: [PATCH 2/2] Fixed tests --- .../src/test/java/com/optimizely/ab/OptimizelyTest.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java b/core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java index 3b953bb59..0817ddc41 100644 --- a/core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java +++ b/core-api/src/test/java/com/optimizely/ab/OptimizelyTest.java @@ -531,7 +531,7 @@ public void activateWithUnknownExperimentKeyAndNoOpErrorHandler() throws Excepti Experiment unknownExperiment = createUnknownExperiment(); Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build(); - logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile."); + logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile."); logbackVerifier.expectMessage(Level.INFO, "Not activating user \"userId\" for experiment \"unknown_experiment\"."); @@ -986,7 +986,7 @@ public void trackEventWithUnknownEventKeyAndNoOpErrorHandler() throws Exception Optimizely optimizely = optimizelyBuilder.withErrorHandler(new NoOpErrorHandler()).build(); - logbackVerifier.expectMessage(Level.ERROR, "Event \"unknown_event_type\" is not in the datafile."); + logbackVerifier.expectMessage(Level.WARN, "Event \"unknown_event_type\" is not in the datafile."); logbackVerifier.expectMessage(Level.INFO, "Not tracking event \"unknown_event_type\" for user \"userId\"."); optimizely.track(unknownEventType.getKey(), testUserId); } @@ -1333,7 +1333,7 @@ public void getVariationWithUnknownExperimentKeyAndNoOpErrorHandler() throws Exc .withErrorHandler(new NoOpErrorHandler()) .build(); - logbackVerifier.expectMessage(Level.ERROR, "Experiment \"unknown_experiment\" is not in the datafile."); + logbackVerifier.expectMessage(Level.WARN, "Experiment \"unknown_experiment\" is not in the datafile."); // since we use a NoOpErrorHandler, we should fail and return null Variation actualVariation = optimizely.getVariation(unknownExperiment.getKey(), testUserId);