8000 Mismatch between `COMP_R_BROTLI_DEFLATE_ERROR` and `COMP_R_BROTLI_ENCODE_ERROR` · Issue #26316 · openssl/openssl · GitHub
[go: up one dir, main page]

Skip to content
Mismatch between COMP_R_BROTLI_DEFLATE_ERROR and COMP_R_BROTLI_ENCODE_ERROR #26316
@ZeroIntensity

Description

@ZeroIntensity

Hi! This was discovered by @picnixz when working on the ssl module in CPython upstream:

There seems to be a mismatch between one of the error codes in openssl.txt and the actual macro definition, which is screwing up a mechanism for handling errors on our end. The offending code is here:

# define COMP_R_BROTLI_ENCODE_ERROR 103

This differs from the provided openssl.txt file, which we use for code generation:

COMP_R_BROTLI_DEFLATE_ERROR:103:brotli deflate error
COMP_R_BROTLI_ENCODE_ERROR:106:brotli encode error

COMP_R_BROTLI_ENCODE_ERROR should be 103, not 106 here, and as far as I can tell, COMP_R_BROTLI_DEFLATE_ERROR doesn't exist anymore. It looks like things were changed in this commit: b67cb09

Let me or @picnixz know if there are any questions, thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0