8000 Cleanup `esbuildSync` and `esbuildAsync` · Issue #276 · opennextjs/opennextjs-aws · GitHub
[go: up one dir, main page]
Skip to content

Cleanup esbuildSync and esbuildAsync #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fwang opened this issue Oct 11, 2023 · 2 comments
Open

Cleanup esbuildSync and esbuildAsync #276

fwang opened this issue Oct 11, 2023 · 2 comments

Comments

@fwang
Copy link
Contributor
fwang commented Oct 11, 2023 •
edited
Loading

They seem identical. Do we need both?
https://github.com/sst/open-next/blob/ba84a002b50f3b69dd78803ad9fa1114a368aed7/packages/open-next/src/build.ts#L763-L821
@khuezy
Copy link
Contributor
khuezy commented Oct 11, 2023 •
edited
Loading

we can get rid of the non async one if it doesn't break the build. We had to use async for the plugin system iirc

@sommeeeer
Copy link
Contributor

@khuezy can you close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fwang @khuezy @sommeeeer
0