8000 Codestyle guidelines · Issue #174 · opennextjs/opennextjs-aws · GitHub
[go: up one dir, main page]
Skip to content

Codestyle guidelines #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its mainta 8000 iners and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sladg opened this issue Aug 11, 2023 · 2 comments · Fixed by #187
Closed

Codestyle guidelines #174

sladg opened this issue Aug 11, 2023 · 2 comments · Fixed by #187

Comments

@sladg
Copy link
Contributor
sladg commented Aug 11, 2023

👋 Looking at my experience as well as some other PRs (https://github.com/sst/open-next/pull/155/files) it would be wise to add Eslint config to the project to ensure we follow same formatting while developing.
@sladg sladg mentioned this issue Aug 11, 2023
Closed
2 tasks
@khuezy
Copy link
Contributor
khuezy commented Aug 11, 2023

Ditto, I had to wrestle w/ my VSCode settings b/c there wasn't a lint config in this project.

@sladg
Copy link
Contributor Author
sladg commented Aug 11, 2023

@khuezy I'm gonna open PR for this, should be fairly simple, we just need to pick right setup for existing codebase 🚀

This was referenced Aug 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Codestyle unification sladg/open-next
Code-style unification sladg/open-next
2 participants
@khuezy @sladg
0