8000 [TASK] Replace node-fetch by @octokit/graphql (#21) · openmsa/commit-message-checker@4d3b065 · GitHub
[go: up one dir, main page]
Skip to content

Commit 4d3b065

Browse files
gilbertsoftgilbertsoft
authored
[TASK] Replace node-fetch by @octokit/graphql (GsActions#21)
This patch replaces the node-fetch module by using the provided functionality of @octokit/graphql the official GitHub API instead. The tests are refactored and enhanced a little bit. Also various dependencies are updated and therefor the not longer needed graphql.d.ts is removed.
1 parent 3a7b8e4 commit 4d3b065

File tree

9 files changed

+8062
-14503
lines changed

9 files changed

+8062
-14503
lines changed

‎.eslintrc.json

Lines changed: 16 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1,58 +1,17 @@
11
{
2-
"plugins": ["jest", "@typescript-eslint"],
3-
"extends": ["plugin:github/es6"],
4-
"parser": "@typescript-eslint/parser",
5-
"parserOptions": {
6-
"ecmaVersion": 9,
7-
"sourceType": "module",
8-
"project": "./tsconfig.json"
9-
},
10-
"rules": {
11-
"eslint-comments/no-use": "off",
12-
"import/no-namespace": "off",
13-
"no-unused-vars": "off",
14-
"@typescript-eslint/no-unused-vars": "error",
15-
"@typescript-eslint/explicit-member-accessibility": ["error", {"accessibility": "no-public"}],
16-
"@typescript-eslint/no-require-imports": "error",
17-
"@typescript-eslint/array-type": "error",
18-
"@typescript-eslint/await-thenable": "error",
19-
"@typescript-eslint/ban-ts-ignore": "error",
20-
"camelcase": "off",
21-
"@typescript-eslint/camelcase": "error",
22-
"@typescript-eslint/class-name-casing": "error",
23-
"@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
24-
"@typescript-eslint/func-call-spacing": ["error", "never"],
25-
"@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
26-
"@typescript-eslint/no-array-constructor": "error",
27-
"@typescript-eslint/no-empty-interface": "error",
28-
"@typescript-eslint/no-explicit-any": "error",
29-
"@typescript-eslint/no-extraneous-class": "error",
30-
"@typescript-eslint/no-for-in-array": "error",
31-
"@typescript-eslint/no-inferrable-types": "error",
32-
"@typescript-eslint/no-misused-new": "error",
33-
"@typescript-eslint/no-namespace": "error",
34-
"@typescript-eslint/no-non-null-assertion": "warn",
35-
"@typescript-eslint/no-object-literal-type-assertion": "error",
36-
"@typescript-eslint/no-unnecessary-qualifier": "error",
37-
"@typescript-eslint/no-unnecessary-type-assertion": "error",
38-
"@typescript-eslint/no-useless-constructor": "error",
39-
"@typescript-eslint/no-var-requires": "error",
40-
"@typescript-eslint/prefer-for-of": "warn",
41-
"@typescript-eslint/prefer-function-type": "warn",
42-
"@typescript-eslint/prefer-includes": "error",
43-
"@typescript-eslint/prefer-interface": "error",
44-
"@typescript-eslint/prefer-string-starts-ends-with": "error",
45-
"@typescript-eslint/promise-function-async": "error",
46-
"@typescript-eslint/require-array-sort-compare": "error",
47-
"@typescript-eslint/restrict-plus-operands": "error",
48-
"semi": "off",
49-
"@typescript-eslint/semi": ["error", "never"],
50-
"@typescript-eslint/type-annotation-spacing": "error",
51-
"@typescript-eslint/unbound-method": "error"
52-
},
53-
"env": {
54-
"node": true,
55-
"es6": true,
56-
"jest/globals": true
57-
}
58-
}
2+
"plugins": ["@typescript-eslint", "github", "jest"],
3+
"extends": ["plugin:github/typescript"],
4+
"parser": "@typescript-eslint/parser",
5+
"parserOptions": {
6+
"ecmaVersion": 9,
7+
"sourceType": "module",
8+
"project": "./tsconfig.json"
9+
},
10+
"rules": {
11+
},
12+
"env": {
13+
"node": true,
14+
"es6": true,
15+
"jest/globals": true
16+
}
17+
}

‎.github/workflows/test.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,5 @@ jobs:
2626
with:
2727
pattern: '\[(BUGFIX|DOCS|FEATURE|TASK)\] .+$'
2828
error: 'Your first line has to contain a commit type like "[BUGFIX]".'
29+
checkAllCommitMessages: 'true'
30+
accessToken: ${{ secrets.GITHUB_TOKEN }}

0 commit comments

Comments
 (0)
0