-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Monte Carlo / Dynamic Code (MC/DC): An accelerated Python package for fully transient neutron transport and rapid methods development #6415
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
@lewisfish @szabo137 checking in here on getting reviews started; you can generate your checklist via:
please let me know if you need to set this down or if you have any other questions/concerns. |
Review checklist for @lewisfishConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@jpmorgan98 For the section in the paper discussing MCDC vs other codes. How does MCDC compare with open source neutron codes such as openMC or GEANT4? Also what codes are hard to aquire, install etc (guessing MCNP?)? It would be good to cite these packages (or others if the ones I chose are not appropriate). |
I will also dig into those issues with the team! Thanks! |
@lewisfish We have edited those sections of the paper to include comments about other software in this space and fixed/explained all the issues you raised in CEMeNT-PSAAP/MCDC#173 and CEMeNT-PSAAP/MCDC#174. The changes have been merged into our main branch. Let me know if there is anything we need from us to complete your review! Thank you again! |
Review checklist for @szabo137Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software pap 8000 er
|
Looks great! One final issue I've noticed is that with the updated doc strings, it seems the readthedocs website has not been rebuilt with them. If you update the online docs I think that the review done from my side. @editorialbot generate pdf |
Ugh right, always more buttons to push. Changes are live. lmk if there's anything further. Thanks again |
I feel your pain. |
@jpmorgan98 First of all, I like the package, and the paper, especially the focus on usability is very positive for scalable software, which is supposed to be executed in HPC environments. Regarding this review, I have no concerns with this one. Beyond this, you could think of adding a docker file to improve the installation procedure even further. |
A docker container is a great idea and I will add an issue to track that! Is there anything else I need to do on my front or is this review done? Thank you both again! |
Looks like the reviewers have checked off all of their boxes, so I'll move along with getting this wrapped up. |
Post-Review Checklist for Editor and AuthorsAdditional Author Tasks After Review is Complete
Editor Tasks Prior to Acceptance
|
@editorialbot generate pdf |
@editorialbot check references |
Done! version is now 0.9.1 |
@editorialbot set 10.5281/zenodo.10576604 as archive |
Done! archive is now 10.5281/zenodo.10576604 |
thanks @jpmorgan98 - can you edit the archive metadata so that:
|
@kellyrowland - fixed |
@editorialbot recommend-accept |
|
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5232, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@lewisfish, @szabo137 – many thanks for your reviews here and to @kellyrowland for editing this submission! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨ @jpmorgan98 – your paper is now accepted and published in JOSS ⚡🚀💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@openjournals/dev it looks like @kellyrowland's name in the "Editor:" field has a different link color - and in fact the link there seems broken. Any idea what's going on? The ORCID link works ok. I assume that is supposed to link to a personal webpage? |
It looks like @kellyrowland's URL on her JOSS editor profile was incomplete. I've fixed it now and will try reaccepting. |
@editorialbot reaccept |
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#5343 |
Submitting author: @jpmorgan98 (J. Piper Morgan)
Repository: https://github.com/CEMeNT-PSAAP/MCDC
Branch with paper.md (empty if default branch):
Version: 0.9.1
Editor: @kellyrowland
Reviewers: @lewisfish, @szabo137
Archive: 10.5281/zenodo.10576604
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@lewisfish & @szabo137, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kellyrowland know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @lewisfish
📝 Checklist for @szabo137
The text was updated successfully, but these errors were encountered: