8000 address review comments · opencv/opencv@28fde50 · GitHub
[go: up one dir, main page]
Skip to content

Commit 28fde50

Browse files
rogdayrogday
committed
address review comments
1 parent f9b7584 commit 28fde50

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

‎modules/dnn/include/opencv2/dnn/layer.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ class CV_EXPORTS LayerFactory
6767
static void unregisterLayer(const String &type);
6868

6969
//! Check if layer is registered.
70-
//! @note Thread-safe, but the mutex will be unlocked after this function terminates.
7170
static bool isLayerRegistered(const std::string& type);
7271

7372
/** @brief Creates instance of registered layer.

‎modules/dnn/src/dnn_common.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ class LayerHandler
114114
return;
115115
}
116116

117-
std::stringstream ss;
117+
std::ostringstream ss;
118118
ss << "DNN: Not supported types:\n";
119119
for (const auto& typeset : layers)
120120
{

‎modules/dnn/src/onnx/onnx_importer.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,6 @@ class ONNXLayerHandler : public detail::PayloadedLayerHandler<LayerPayload>
209209

210210
protected:
211211
ONNXImporter* importer;
212-
const std::string str_domain_ai_onnx = "ai.onnx";
213212
};
214213

215214
ONNXLayerHandler::ONNXLayerHandler(ONNXImporter* importer_) : importer(importer_){}
@@ -891,7 +890,7 @@ void ONNXImporter::handleNode(const opencv_onnx::NodeProto& node_proto)
891890
const auto& dispatch = getDispatchMap(node_proto);
892891

893892
bool declared_domain = onnx_opset_map.find(layer_type_domain) != onnx_opset_map.end();
894-
CV_LOG_WARNING(NULL, "DNN/ONNX: processing node with " << node_proto.input_size() << " inputs and "
893+
CV_LOG_DEBUG(NULL, "DNN/ONNX: processing node with " << node_proto.input_size() << " inputs and "
895894
<< node_proto.output_size() << " outputs: "
896895
<< cv::format("[%s]:(%s)", layer_type.c_str(), name.c_str())
897896
<< cv::format(" from %sdomain='", declared_domain ? "" : "undeclared ")

‎modules/dnn/src/tensorflow/tf_importer.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3090,8 +3090,8 @@ void TFImporter::populateNet()
30903090
{
30913091
const tensorflow::NodeDef& layer = net.node(li);
30923092

3093-
CV_LOG_DEBUG(NULL, "DNN/TF: (" << li << "/" << layersSize << ") Parse layer "
3094-
<< layer.name() << " @ " << layer.op() << " with " << layer.input_size() << " inputs");
3093+
CV_LOG_DEBUG(NULL, "DNN/TF: processing node (" << li << "/" << layersSize << ") with " << layer.input_size() << " inputs: "
3094+
<< cv::format("[%s]:(%s)", layer.op().c_str(), layer.name().c_str()));
30953095

30963096
parseNode(layer);
30973097
}

0 commit comments

Comments
 (0)
0