8000 Changing the src/agents/models/openai_chatcompletions.py into smaller parts · Issue #119 · openai/openai-agents-python · GitHub
[go: up one dir, main page]

Skip to content
Changing the src/agents/models/openai_chatcompletions.py into smaller parts #119
Open
@debuggerone

Description

@debuggerone

Please read this first

  • Have you read the docs?Agents SDK docs
  • Have you searched for related issues? Others may have had similar requesrs

Question

Hey Rohan,

I did a little analysis on your code.

Image

Do you think we can split it up in a way that you originally thought you would do that?
I mean look at your tests - beautifully organized (except that we can split one up a little bit more as well), and then it had to be released before you did that final refactoring? Right?

I am building a little pipeline which could auto transform the python code into Typescript.

I did some similar stuff in the past (but from Typescript to Python).

I mean when it works the SDK could also be released in multiple languages.

The thing is when we change that so it becomes digestable for the models for the autotransform we need to change the imports/usage of the tests or introduce a helper that provides backwards compatibility (and I mean I would do a pull request but changing tests is something I'd rather discuss first).

ping me at https://community.openai.com/u/jochenschultz

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionQuestion about using the SDKstale

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0