Fix Marshal outputs json text representation of nil

m-posluszny · m-posluszny · commit fafac78bffa0 · 2024-01-19T19:07:45.000+01:00
diff --git a/exporters/stdout/stdoutmetric/example_test.go b/exporters/stdout/stdoutmetric/example_test.go
@@ -257,8 +257,8 @@ func Example() {
 	//                   6,
 	//                   0
 	//                 ],
-	//                 "Min": {},
-	//                 "Max": {},
+	//                 "Min": null,
+	//                 "Max": null,
 	//                 "Sum": 57
 	//               }
 	//             ],
diff --git a/sdk/metric/metricdata/data.go b/sdk/metric/metricdata/data.go
@@ -215,7 +215,7 @@ type Extrema[N int64 | float64] struct {
 // MarshalText converts the Extrema value to text.
 func (e Extrema[N]) MarshalText() ([]byte, error) {
 	if !e.valid {
-		return nil, nil
+		return json.Marshal(nil)
 	}
 	return json.Marshal(e.value)
 }

Original file line number	Diff line number	Diff line change
`@@ -215,7 +215,7 @@ type Extrema[N int64 \| float64] struct {`
`215`	`215`	`// MarshalText converts the Extrema value to text.`
`216`	`216`	`func (e Extrema[N]) MarshalText() ([]byte, error) {`
`217`	`217`	`if !e.valid {`
`218`		`- return nil, nil`
	`218`	`+ return json.Marshal(nil)`
`219`	`219`	`}`
`220`	`220`	`return json.Marshal(e.value)`
`221`	`221`	`}`