Apply suggestions from code review

marcalff · web-flow · commit 9db948dcb978 · 2024-11-24T21:09:42.000+01:00
diff --git a/sdk/include/opentelemetry/sdk/trace/span_data.h b/sdk/include/opentelemetry/sdk/trace/span_data.h
@@ -254,8 +254,10 @@ class SpanData final : public Recordable
   }
 
   void AddEvent(nostd::string_view name,
-                opentelemetry::common::SystemTimestamp timestamp,
-                const opentelemetry::common::KeyValueIterable &attributes) noexcept override
+                opentelemetry::common::SystemTimestamp timestamp =
+                    opentelemetry::common::SystemTimestamp(std::chrono::system_clock::now()),
+                const opentelemetry::common::KeyValueIterable &attributes =
+                    opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>) noexcept override
   {
     SpanDataEvent event(std::string(name), timestamp, attributes);
     events_.push_back(event);
diff --git a/sdk/test/trace/span_data_test.cc b/sdk/test/trace/span_data_test.cc
@@ -69,8 +69,7 @@ TEST(SpanData, Set)
   data.SetStartTime(now);
   data.SetDuration(std::chrono::nanoseconds(1000000));
   data.SetAttribute("attr1", static_cast<int64_t>(314159));
-  data.AddEvent("event1", now,
-                opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>({}));
+  data.AddEvent("event1", now);
 
   ASSERT_EQ(data.GetTraceId(), trace_id);
   ASSERT_EQ(data.GetSpanId(), span_id);

Original file line number	Diff line number	Diff line change
`@@ -254,8 +254,10 @@ class SpanData final : public Recordable`
`254`	`254`	`}`
`255`	`255`
`256`	`256`	`void AddEvent(nostd::string_view name,`
`257`		`- opentelemetry::common::SystemTimestamp timestamp,`
`258`		`- const opentelemetry::common::KeyValueIterable &attributes) noexcept override`
	`257`	`+ opentelemetry::common::SystemTimestamp timestamp =`
	`258`	`+ opentelemetry::common::SystemTimestamp(std::chrono::system_clock::now()),`
	`259`	`+ const opentelemetry::common::KeyValueIterable &attributes =`
	`260`	`+ opentelemetry::common::KeyValueIterableView<std::map<std::string, int32_t>>) noexcept override`
`259`	`261`	`{`
`260`	`262`	`SpanDataEvent event(std::string(name), timestamp, attributes);`
`261`	`263`	`events_.push_back(event);`