Missed a spot with the context manager

t8y8 · t8y8 · commit be4c9c8ecc5d · 2016-06-30T12:14:44.000-07:00
diff --git a/tableaudocumentapi/containerfile.py b/tableaudocumentapi/containerfile.py
@@ -19,9 +19,10 @@ def temporary_directory(*args, **kwargs):
 def find_file_in_zip(zip):
     for filename in zip.namelist():
         try:
-            ET.parse(zip.open(filename)).getroot().tag in (
-                'workbook', 'datasource')
-            return filename
+            with zip.open(filename) as xml_candidate:
+                ET.parse(xml_candidate).getroot().tag in (
+                    'workbook', 'datasource')
+                return filename
         except ET.ParseError:
             # That's not an XML file by gosh
             pass
