Adapter factory? #94

justinmchase · 2022-05-19T19:18:54Z

I am trying to use east programmatically, I already have a mongo client and connection, but I can't figure out how to just provide that connection to east already.

const { mongo } = services // already configured and connected

 await migrationManager.configure({
  adapter: new MongoAdapter(mongo) // err
})

justinmchase · 2022-05-19T22:23:05Z

I'm not sure how to solve it per se but basically it would be nice if the adapter could accept a string, a class or a factory function which gives you the instance rather than relying on you to construct the adapter.

For example something like this may work:

const { mongo } = services // already configured and connected

 await migrationManager.configure({
  adapter: undefined,
  adapterFactory: () => new MongoAdapter(mongo)
})

okv · 2022-05-25T09:58:05Z

Hi, that configure method's adapter parameter can already be a function or a path to a module that exposes adapter's constructor. In case of the function adapter's constructor is expected to be returned. There is no way to pass an instance of an adapter because East fully controls adapter's lifecycle (connects it, disconnects it, etc).

justinmchase · 2022-05-25T14:59:00Z

There is no way to pass an instance of an adapter because East fully controls adapter's lifecycle (connects it, disconnects it, etc).

Except when run programmatically in another application. I really need to control the construction specifically in that case.

I have a workaround fortunately:

  const { services } = context
  const { mongo } = services // already configured and connected

  class DynamicAdapter extends Adapter<TContext> {
      private migrations: Collection<IMigration>    
      public async connect(): Promise<TContext> {
        this.migrations = mongo.getCollection<IMigration>('migrations') // references mongo instance in higher scope
        return await Promise.resolve(context)
      }
      // etc...
  }

  await migrationManager.configure({
    adapter: DynamicAdapter
  })

I need to do this because I need more than just a database connection for migrations, I need a full context of my application, connections to multiple services, etc. For example, if you update a particular database record you may need to also push a message into a stream or queue or call a 3rd party api.

So anyway, I have a workaround but its inellegant, I think it would be very helpful to make it possible to accept adapter instances for programmatic uses rather than require a constructor specifically.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapter factory? #94

Adapter factory? #94

Adapter factory? #94

Adapter factory? #94

Comments