DOC add comment in check_pca_float_dtype_preservation (scikit-learn#15819)

adrinjalali · ogrisel · commit db288e12670a · 2020-01-02T10:43:42.000+01:00
Documenting the changes in scikit-learn#15775
diff --git a/sklearn/decomposition/tests/test_pca.py b/sklearn/decomposition/tests/test_pca.py
@@ -532,6 +532,9 @@ def check_pca_float_dtype_preservation(svd_solver):
     assert pca_64.transform(X_64).dtype == np.float64
     assert pca_32.transform(X_32).dtype == np.float32
 
+    # the rtol is set such that the test passes on all platforms tested on
+    # conda-forge: PR#15775
+    # see: https://github.com/conda-forge/scikit-learn-feedstock/pull/113
     assert_allclose(pca_64.components_, pca_32.components_, rtol=2e-4)
 
 

Original file line number	Diff line number	Diff line change
`@@ -532,6 +532,9 @@ def check_pca_float_dtype_preservation(svd_solver):`
`532`	`532`	`assert pca_64.transform(X_64).dtype == np.float64`
`533`	`533`	`assert pca_32.transform(X_32).dtype == np.float32`
`534`	`534`
	`535`	`+ # the rtol is set such that the test passes on all platforms tested on`
	`536`	`+ # conda-forge: PR#15775`
	`537`	`+ # see: https://github.com/conda-forge/scikit-learn-feedstock/pull/113`
`535`	`538`	`assert_allclose(pca_64.components_, pca_32.components_, rtol=2e-4)`
`536`	`539`
`537`	`540`