[FIX] base_vat: correct the method check_vat_il to not call self.company

mathcoutant · mathcoutant · commit dacabd67bd9e · 2024-07-30T07:57:40.000Z
In this PR: odoo#172760 the check_vat_il function is calling self.company. It appears it was not a good idea and several things were not done well: - It could lead to errors as run_vat_test can be called on multiple partners: https://github.com/odoo/odoo/blob/16.0/addons/base_vat/models/res_partner.py#L170. - The previous PR is also checking the VAT number depending on the field is_company but did not put it as a constraint. This can be fixed, but with more changes than needed. It has been decided to use the `` check for all Israeli VAT numbers, regardless of the partner type. With this change the VAT check for companies is not complete: it is not tested that they begin by a 5. But it is good enough. opw-3954674 closes odoo#174817 Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
diff --git a/addons/base_vat/models/res_partner.py b/addons/base_vat/models/res_partner.py
@@ -822,7 +822,7 @@ def check_vat_de(self, vat):
         return is_valid_vat(vat) or is_valid_stnr(vat)
 
     def check_vat_il(self, vat):
-        check_func = stdnum.util.get_cc_module('il', 'hp').is_valid if self.is_company else stdnum.util.get_cc_module('il', 'idnr').is_valid
+        check_func = stdnum.util.get_cc_module('il', 'idnr').is_valid
         return check_func(vat)
 
     def format_vat_sm(self, vat):
