[FIX] purchase_stock: Fallback on archived picking type

amoyaux · amoyaux · commit ad4f6d4784e1 · 2025-05-16T21:35:20.000Z
In 18.0 the warehouse on new company is optional and different document raise a redirectWarning when needed. However picking_type_id is required in 18.0 but it's an error since service or other purchase don't need it. So we just add an archived picking type if we don't find a default. So user can create a multi company incoming picking type and use it to automaticaly filter and bypass the error. We also remove the rediret warning at this point. In master we will remove the optional and delete this hack closes #194897 Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
diff --git a/addons/purchase_stock/models/purchase_order.py b/addons/purchase_stock/models/purchase_order.py
@@ -253,9 +253,8 @@ def _get_picking_type(self, company_id):
         picking_type = self.env['stock.picking.type'].search([('code', '=', 'incoming'), ('warehouse_id.company_id', '=', company_id)])
         if not picking_type:
             picking_type = self.env['stock.picking.type'].search([('code', '=', 'incoming'), ('warehouse_id', '=', False)])
-        company_warehouse = self.env['stock.warehouse'].search([('company_id', '=', company_id)], limit=1)
-        if not company_warehouse:
-            self.env['stock.warehouse']._warehouse_redirect_warning()
+        if not picking_type:
+            picking_type = self.env['stock.picking.type'].with_context(active_test=False).search([('code', '=', 'incoming'), ('warehouse_id', '=', False)])
         return picking_type[:1]
 
     def _prepare_group_vals(self):
