FIX - flutter-webrtc#295

wer-mathurin · wer-mathurin · commit ce0c36216f5b · 2020-07-28T18:32:33.000-04:00
ADD - Comment for discussion
diff --git a/.gitignore b/.gitignore
@@ -13,3 +13,4 @@ example/android/gradle*
 WorkspaceSettings.xcsettings
 example/.flutter-plugins
 example/android/local.properties
+.dart_tool/package_config.json
diff --git a/lib/web/rtc_video_view.dart b/lib/web/rtc_video_view.dart
@@ -81,7 +81,7 @@ class RTCVideoRenderer {
     ui.platformViewRegistry.registerViewFactory(stream.id, (int viewId) {
       final x = HTML.VideoElement();
       x.autoplay = true;
-      x.muted = false;
+      x.muted = true;
       x.srcObject = stream.jsStream;
       x.id = stream.id;
       _htmlVideoElement = x;
@@ -149,6 +149,7 @@ class RTCVideoRenderer {
 
   Future<Null> dispose() async {
     //TODO?
+    //https://stackoverflow.com/questions/3258587/how-to-properly-unload-destroy-a-video-element/28060352
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ class RTCVideoRenderer {`
`81`	`81`	`ui.platformViewRegistry.registerViewFactory(stream.id, (int viewId) {`
`82`	`82`	`final x = HTML.VideoElement();`
`83`	`83`	`x.autoplay = true;`
`84`		`- x.muted = false;`
	`84`	`+ x.muted = true;`
`85`	`85`	`x.srcObject = stream.jsStream;`
`86`	`86`	`x.id = stream.id;`
`87`	`87`	`_htmlVideoElement = x;`
`@@ -149,6 +149,7 @@ class RTCVideoRenderer {`
`149`	`149`
`150`	`150`	`Future<Null> dispose() async {`
`151`	`151`	`//TODO?`
	`152`	`+ //https://stackoverflow.com/questions/3258587/how-to-properly-unload-destroy-a-video-element/28060352`
`152`	`153`	`}`
`153`	`154`	`}`
`154`	`155`