Expanded validation for BE VAT numbers

JonasGe · arthurdejong · commit 3a592e472ffd · 2020-11-07T15:23:25.000+01:00
Specifically invalidated all-zero numbers Closes arthurdejong#240
diff --git a/stdnum/be/vat.py b/stdnum/be/vat.py
@@ -61,7 +61,7 @@ def validate(number):
     """Check if the number is a valid VAT number. This checks the length,
     formatting and check digit."""
     number = compact(number)
-    if not isdigits(number):
+    if not isdigits(number) or int(number) <= 0:
         raise InvalidFormat()
     if len(number) != 10:
         raise InvalidLength()
diff --git a/tests/test_be_vat.doctest b/tests/test_be_vat.doctest
@@ -0,0 +1,37 @@
+test_be_vat.doctest - more detailed doctests for stdnum.be.vat module
+
+Copyright (C) 2020 Arthur de Jong
+
+This library is free software; you can redistribute it and/or
+modify it under the terms of the GNU Lesser General Public
+License as published by the Free Software Foundation; either
+version 2.1 of the License, or (at your option) any later version.
+
+This library is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public
+License along with this library; if not, write to the Free Software
+Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+02110-1301 USA
+
+
+This file contains more detailed doctests for the stdnum.be.vat module. It
+tries to test more corner cases and detailed functionality that is not
+really useful as module documentation.
+
+>>> from stdnum.be import vat
+
+
+Tests for corner cases.
+
+>>> vat.validate('BE0000000000')
+Traceback (most recent call last):
+    ...
+InvalidFormat: ...
+>>> vat.validate('000000')
+Traceback (most recent call last):
+    ...
+InvalidFormat: ...
