BUG: prototypes for [cz]dot[uc] are incorrect #9997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
F2C does not support complex return values.
|
So these definitions are currently not being used at all? |
|
Do we want a test for these functions? |
|
Because the numpy functions are in C, I think that f2c_blas and lapack_lite are always paired. Multiarray does use the dot functions, but from CBLAS, with its own fallback C implementations. How did you manage to call the f2c_blas functions? |
|
LGTM, I don't think there is a problem ... |
|
Yeah, let's merge this, I don't see a problem. Thanks Eric. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
F2C does not support complex return values, and puts these as the first argument.
This can be checked by looking at
numpy\linalg\lapack_lite\f2c_blas.c.It's not clear to me if these prototypes are exclusively for lapack_lite, or if they also need to match the system lapack (in which case the
f2c_...in the typenames is very misleading).This fixed a segfault on my machine (using lapack_lite) when trying to call these functions in the C code.